Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More/update download info #95

Merged
merged 30 commits into from
Jul 1, 2014
Merged

More/update download info #95

merged 30 commits into from
Jul 1, 2014

Conversation

nspruit
Copy link
Collaborator

@nspruit nspruit commented Jun 30, 2014

  • Update the download info screen when looking at an individual torrent (poll for downloads.get_progress_info()),
  • Show size, percentage, ... in the download list.

@wtud wtud added this to the Search and stream prototype milestone Jun 18, 2014
@wtud wtud changed the title Show and update correct information in download info screen More/update download info Jun 20, 2014
@nspruit
Copy link
Collaborator

nspruit commented Jun 30, 2014

I'm working on this right now

@tribler-ci
Copy link
Collaborator

Test FAILED.
Refer to this link for build results: http://jenkins.tribler.org/job/Build_Test-TSAP_Android_pull-requests/276/

@nspruit
Copy link
Collaborator

nspruit commented Jun 30, 2014

The download info screen should now display the correct information (that will also be updated every two seconds). However, the type field doesn't show the correct info yet as the result map of performing one of the following RPC calls doesn't contain this information: downloads.get_progress_info or downloads.get_all_progress_info. @wtud Maybe you could look into this?

Also, please let me now if and what additional info needs to added to this screen.

@nspruit
Copy link
Collaborator

nspruit commented Jun 30, 2014

retest this please

@tribler-ci
Copy link
Collaborator

Test FAILED.
Refer to this link for build results: http://jenkins.tribler.org/job/Build_Test-TSAP_Android_pull-requests/277/

@nspruit
Copy link
Collaborator

nspruit commented Jun 30, 2014

TODO: use MainThreadPoller?

@tribler-ci
Copy link
Collaborator

Test FAILED.
Refer to this link for build results: http://jenkins.tribler.org/job/Build_Test-TSAP_Android_pull-requests/280/

@nspruit
Copy link
Collaborator

nspruit commented Jun 30, 2014

retest this please

@nspruit
Copy link
Collaborator

nspruit commented Jun 30, 2014

@wtud I've added the additional info you suggested except the availability. Let me know what you think of it. I've haven't added the availability info (yet) as I don't know what that number means. Do you know what it represents?

@tribler-ci
Copy link
Collaborator

Test PASSED.
Refer to this link for build results: http://jenkins.tribler.org/job/Build_Test-TSAP_Android_pull-requests/290/

@wtud
Copy link
Owner Author

wtud commented Jun 30, 2014

@nspruit Availability >= 1 means that the full file is available from peers.

From the Tribler source:

def get_availability(self):
""" Return overall the availability of all pieces, using connected peers
Availability is defined as the number of complete copies of a piece, thus seeders
increment the availability by 1. Leechers provide a subset of piece thus we count the
overall availability of all pieces provided by the connected peers and use the minimum
of this + the average of all additional pieces.
"""

@nspruit
Copy link
Collaborator

nspruit commented Jun 30, 2014

Ok thanks, I'll add it to the screen

@nspruit
Copy link
Collaborator

nspruit commented Jun 30, 2014

@wtud I've added the availability to the screen, although I haven't seen it to be another value than 0 yet. Let me know what you think of the current layout etc.

@tribler-ci
Copy link
Collaborator

Test PASSED.
Refer to this link for build results: http://jenkins.tribler.org/job/Build_Test-TSAP_Android_pull-requests/292/

@wtud
Copy link
Owner Author

wtud commented Jun 30, 2014

@nspruit looks okay, though the speed is shown twice now, and progress fully hidden in landscape mode. Why not put it next to the thumbnail?

I'll look into the availability staying 0 later.

@nspruit
Copy link
Collaborator

nspruit commented Jun 30, 2014

@wtud Put what exactly next to the thumbnail?

@wtud
Copy link
Owner Author

wtud commented Jun 30, 2014

@nspruit The eta/download status

@nspruit
Copy link
Collaborator

nspruit commented Jun 30, 2014

@wtud I thought that wouldn't fit, but I'll try it

@nspruit
Copy link
Collaborator

nspruit commented Jun 30, 2014

@wtud This is what you get when you put it next to the thumbnail, it doesn't fit properly when using LinearLayouts

@tribler-ci
Copy link
Collaborator

Test PASSED.
Refer to this link for build results: http://jenkins.tribler.org/job/Build_Test-TSAP_Android_pull-requests/295/

@wtud
Copy link
Owner Author

wtud commented Jun 30, 2014

@nspruit I see. Maybe give the download status its own row, on top of the progress bar and fully below the thumbnail, without the Status: prefix? If you right align the text, i guess it should still look pretty well.

@tribler-ci
Copy link
Collaborator

Test PASSED.
Refer to this link for build results: http://jenkins.tribler.org/job/Build_Test-TSAP_Android_pull-requests/297/

@tribler-ci
Copy link
Collaborator

Test PASSED.
Refer to this link for build results: http://jenkins.tribler.org/job/Build_Test-TSAP_Android_pull-requests/298/

nspruit added a commit that referenced this pull request Jul 1, 2014
@nspruit nspruit merged commit 113d5d5 into master Jul 1, 2014
@nspruit nspruit deleted the updateDownloadInfo branch July 1, 2014 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants