-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More/update download info #95
Conversation
I'm working on this right now |
Test FAILED. |
The download info screen should now display the correct information (that will also be updated every two seconds). However, the type field doesn't show the correct info yet as the result map of performing one of the following RPC calls doesn't contain this information: Also, please let me now if and what additional info needs to added to this screen. |
retest this please |
Test FAILED. |
TODO: |
Test FAILED. |
retest this please |
@wtud I've added the additional info you suggested except the availability. Let me know what you think of it. I've haven't added the availability info (yet) as I don't know what that number means. Do you know what it represents? |
Test PASSED. |
@nspruit Availability >= 1 means that the full file is available from peers. From the Tribler source: def get_availability(self):
""" Return overall the availability of all pieces, using connected peers
Availability is defined as the number of complete copies of a piece, thus seeders
increment the availability by 1. Leechers provide a subset of piece thus we count the
overall availability of all pieces provided by the connected peers and use the minimum
of this + the average of all additional pieces.
""" |
Ok thanks, I'll add it to the screen |
@wtud I've added the availability to the screen, although I haven't seen it to be another value than 0 yet. Let me know what you think of the current layout etc. |
Test PASSED. |
@nspruit looks okay, though the speed is shown twice now, and progress fully hidden in landscape mode. Why not put it next to the thumbnail? I'll look into the availability staying 0 later. |
@wtud Put what exactly next to the thumbnail? |
@nspruit The eta/download status |
@wtud I thought that wouldn't fit, but I'll try it |
@wtud This is what you get when you put it next to the thumbnail, it doesn't fit properly when using LinearLayouts |
Test PASSED. |
@nspruit I see. Maybe give the download status its own row, on top of the progress bar and fully below the thumbnail, without the Status: prefix? If you right align the text, i guess it should still look pretty well. |
Test PASSED. |
Test PASSED. |
downloads.get_progress_info()
),