Add mapping of OIDC client user to iRODS user #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When OIDC is enabled, switch off Sqyrrl's current mode of showing only public (iRODS group) data, but showing it to all clients. Instead, when OIDC is enabled, Sqyrrl maps the authenticated OIDC client user to an iRODS user of the same name and then uses the standard iRODS permissions model. In this mode a client can see "public" data only if their mapped iRODS user is a member of the public iRODS group. Sqyrrl's HTTP session manager is now passed to its constructor so that it ois accessible to be externally configured and also to simplify testing because fake OIDC sessions can be set up to test the HTTP handlers, without the need for an OIDC server or mocks.
kjsanger
force-pushed
the
feature/oidc-irods-groups
branch
from
dc0d6bb to
c719b24
Compare
dkj
reviewed
Nov 29, 2024
kjsanger
commented
Nov 29, 2024
dkj
reviewed
Nov 29, 2024
dkj
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When OIDC is enabled, switch off Sqyrrl's current mode of showing only public (iRODS group) data, but showing it to all clients.
Instead, when OIDC is enabled, Sqyrrl maps the authenticated OIDC client user to an iRODS user of the same name and then uses the standard iRODS permissions model. In this mode a client can see "public" data only if their mapped iRODS user is a member of the public iRODS group.
Sqyrrl's HTTP session manager is now passed to its constructor so that it is accessible to be externally configured and also to simplify testing because fake OIDC sessions can be set up to test the HTTP handlers, without the need for an OIDC server or mocks.