Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ML warehouse #94

Merged
merged 2 commits into from
Nov 15, 2016
Merged

Use ML warehouse #94

merged 2 commits into from
Nov 15, 2016

Conversation

keithj
Copy link
Contributor

@keithj keithj commented Nov 14, 2016

Subsumes #92

@keithj keithj mentioned this pull request Nov 14, 2016
Closed
dkj
dkj reviewed Nov 14, 2016
View reviewed changes
bin/populate_wtsi_irods_groups.pl
else {
$rs = $schema->resultset(q(CurrentStudy));
}
my $mlwh = WTSI::DNAP::Warehouse::Schema->connect;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any need for a or $log->logcroak( here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DBIC dies on error, and the stack trace goes to STDERR. Trapping the error and re-throwing it with logging would help.

@dkj dkj self-assigned this Nov 15, 2016
@dkj dkj merged commit d4abb20 into wtsi-npg:devel Nov 15, 2016
@keithj keithj deleted the use-ldap-and-mlwh branch November 30, 2016 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkj dkj dkj left review comments

Assignees

@dkj dkj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keithj @dkj @kjsanger