Consolidate acl rules #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously no end-user access was provided to unconcented human split-out data. For each study a new iRODS group will be created. This pull request enables access to the nonconcented human data via this new group.
Consolidated all logic about study-related ACLs in the expected_groups method of WTSI::NPG::iRODS::Path thus making this part of logic independent of the sequencing platform. In future this logic can be applied, if necessary, to iRODS collections. Elements of this logic are moved from WTSI::NPG::iRODS::DataObject. The logic related to xahuman is currently inplemented in npg_irods GitHub package.
mgcam
added a commit
to mgcam/npg_irods
that referenced
this pull request
Dec 15, 2023
This pr builds on wtsi-npg/perl-irods-wrap#297, where all existing rules are consolidated in one method.
Disregard file names when assessing what study-related iRODS groups should be assigned to the entity.
kjsanger
approved these changes
Jan 12, 2024
mgcam
added a commit
to mgcam/npg_irods
that referenced
this pull request
Jan 12, 2024
This pr builds on wtsi-npg/perl-irods-wrap#297, where all existing rules are consolidated in one method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #296, but can be considered as self-contained on its own merits
Should be followed by wtsi-npg/npg_irods#439