Added to fixtures an extra study-specific iRODS group #293
Conversation
| /testZone/trash/home | ||
| /testZone/trash/home/irods | ||
| /testZone/trash/home/public ) ) { | ||
| ok ((any { $_ =~ /\A$c\Z/ } @colls), "$c is listed"); |
There was a problem hiding this comment.
What was the reason for changing this test? It seems unrelated to the rest of the changes.
There was a problem hiding this comment.
(From the commit message: it's to work around the tests failing if there's state left from previous rounds of testing.)
The tests should start with iRODS in a known state. The cleanest way to do that is to start a new server, or to make a more effective clean-up method (or script) to remove everything and ensure that it is run before the suite. (The suite already tries to clean up anything it creates).
I don't agree that changing individual tests is a good thing; it addresses only that test and there are many others which haven't been hardened to work around unexpected state on the server.
There was a problem hiding this comment.
Most likely other unit tests are not as sensitive as this one because they look at collections and objects which are created at a particular location for the purpose of the particular test.
There was a problem hiding this comment.
Anything involving metadata is sensitive to global state (within the same zone).
There was a problem hiding this comment.
I'm not going to block this, please feel free to merge.
mgcam
force-pushed
the
extend_fixtures
branch
from
89e69e3 to
cd95d4f
Compare
Tesing whether adding ss_<id_run>_study iRODS group makes any existing tests to fail.