Remove defunct methods and tests, activate all tests #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
The methods that I removed are not used in our codebase, except in their own tests. |
This was referenced Aug 19, 2021
kjsanger
force-pushed
the
feature/test-maintenance
branch
2 times, most recently
from
d3bd8b9 to
c38d222
Compare
|
This is blocked by wtsi-npg/baton#246 |
kjsanger
force-pushed
the
feature/test-maintenance
branch
4 times, most recently
from
dde5279 to
a423f2b
Compare
Remove remove_replicate and prune_replicates methods now that replicates are handled by iRODS' resources. Remove corresponding tests. Simplify replicate counting tests. The test for the invalid_replicates method no longer covers the case where invalid replicates exist. They are now much harder to generate in iRODS, so we'd need to mock iRODS for this case. Fix the check for tests needing admin rights. Remove TEST_AUTHOR because 1) tests always need an iRODS server 2) we are the authors, so we always want all the tests to run. Add iRODS 4.2.10 and baton 3.1.0 to the test matrix.
kjsanger
force-pushed
the
feature/test-maintenance
branch
from
a423f2b to
e2041cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove remove_replicate and prune_replicates methods now that
replicates are handled by iRODS' resources. Remove corresponding
tests.
Simplify replicate counting tests. The test for the invalid_replicates
method no longer covers the case where invalid replicates exist. They
are now much harder to generate in iRODS, so we'd need to mock iRODS
for this case.
Fix the check for tests needing admin rights.
Add iRODS 4.2.10 to the test matrix.