Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token auth for creating a new pipeline #33

Merged
merged 8 commits into from
Mar 10, 2022

Conversation

mgcam
Copy link
Member

@mgcam mgcam commented Mar 10, 2022

Built on top of #32

mgcam added 8 commits March 8, 2022 22:54
Token-based authorization, initially for the pipeline
endpoints only, the pipeline the token belongs to is not
validated in the context of the request.
Restrict the tokens to hexadecimal.
Store the compiled regular expression as a module-level variable.
Use private module-level variables.
A special token is required to create a pipeline.

Documentation for pipeline end points is added/extended.

To improve code readability, added blank lines in accordance
with https://peps.python.org/pep-0008/#blank-lines
@mgcam mgcam requested a review from nerdstrike March 10, 2022 11:39
Copy link
Contributor

@nerdstrike nerdstrike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obviously we'll need to add auth to the tasks API too

@nerdstrike nerdstrike merged commit 45fa130 into wtsi-npg:devel Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants