Merge branch 'devel' into stabilize_deps

wtsi-npg · Aug 15, 2023 · f93107d · f93107d
2 parents 6b36e5c + 23cdb35
commit f93107d
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 14 deletions.
diff --git a/.github/workflows/python-app.yml b/.github/workflows/python-app.yml
@@ -15,7 +15,7 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - name: Set up Python 3.10
       uses: actions/setup-python@v2
       with:

diff --git a/setup.py b/setup.py
@@ -21,11 +21,11 @@
         'aiosqlite',
         'asyncpg',
         'fastapi',
-        'httpx', # missing dep for another dep
         'pydantic<2',
         'pysqlite3',
         'psycopg2-binary',
         'sqlalchemy>=1.4.29,<2',
+        'starlette>=0.22.0',
         'ujson',
         'uvicorn',
         'uuid'
@@ -35,7 +35,8 @@
             'pytest',
             'pytest-asyncio',
             'requests',
-            'flake8'
+            'flake8',
+            'httpx'
         ]
     }
 )
diff --git a/tests/pipeline_route_test.py b/tests/pipeline_route_test.py
@@ -16,18 +16,18 @@
 def http_create_pipeline(fastapi_testclient, pipeline):
 
     response = fastapi_testclient.post(
-        '/pipelines', json=pipeline.dict(), allow_redirects=True
+        '/pipelines', json=pipeline.dict(), follow_redirects=True
     )
     assert response.status_code == status.HTTP_403_FORBIDDEN
 
     response = fastapi_testclient.post(
-        '/pipelines', json=pipeline.dict(), allow_redirects=True,
+        '/pipelines', json=pipeline.dict(), follow_redirects=True,
         headers=headers
     )
     assert response.status_code == status.HTTP_403_FORBIDDEN
 
     response = fastapi_testclient.post(
-        '/pipelines', json=pipeline.dict(), allow_redirects=True,
+        '/pipelines', json=pipeline.dict(), follow_redirects=True,
         headers=headers4power_user
     )
     assert response.status_code == status.HTTP_201_CREATED
@@ -116,7 +116,7 @@ def test_create_pipeline(async_minimum, fastapi_testclient):
     response = fastapi_testclient.post(
         '/pipelines',
         json=desired_pipeline.dict(),
-        allow_redirects=True,
+        follow_redirects=True,
         headers=headers4power_user
     )
     assert response.status_code == status.HTTP_409_CONFLICT, 'ptest two already in DB'
@@ -148,7 +148,7 @@ def test_create_pipeline(async_minimum, fastapi_testclient):
     response = fastapi_testclient.post(
         '/pipelines',
         json=third_desired_pipeline.dict(),
-        allow_redirects=True,
+        follow_redirects=True,
         headers=headers4power_user
     )
     assert response.status_code == status.HTTP_400_BAD_REQUEST
diff --git a/tests/task_route_test.py b/tests/task_route_test.py
@@ -28,7 +28,7 @@ def test_task_creation(async_minimum, fastapi_testclient):
     response = fastapi_testclient.post(
         'tasks',
         json=task_one.dict(),
-        allow_redirects=True,
+        follow_redirects=True,
         headers=headers4ptest_one
     )
     assert response.status_code == status.HTTP_201_CREATED
@@ -38,7 +38,7 @@ def test_task_creation(async_minimum, fastapi_testclient):
     response = fastapi_testclient.post(
         'tasks',
         json=task_one.dict(),
-        allow_redirects=True,
+        follow_redirects=True,
         headers=headers4ptest_one
     )
     assert response.status_code == status.HTTP_409_CONFLICT
@@ -56,7 +56,7 @@ def test_task_creation(async_minimum, fastapi_testclient):
     response = fastapi_testclient.post(
         'tasks',
         json=task_two.dict(),
-        allow_redirects=True,
+        follow_redirects=True,
         headers=headers4ptest_one
     )
     assert response.status_code == status.HTTP_403_FORBIDDEN
@@ -71,7 +71,7 @@ def test_task_update(async_minimum, fastapi_testclient):
     response = fastapi_testclient.put(
         '/tasks',
         json=task,
-        allow_redirects=True,
+        follow_redirects=True,
         headers=headers4ptest_one
     )
     assert response.status_code == status.HTTP_200_OK
@@ -86,7 +86,7 @@ def test_task_update(async_minimum, fastapi_testclient):
     response = fastapi_testclient.put(
         '/tasks',
         json=modified_task.dict(),
-        allow_redirects=True,
+        follow_redirects=True,
         headers=headers4ptest_one
     )
     assert response.status_code == status.HTTP_404_NOT_FOUND
@@ -101,7 +101,7 @@ def test_task_update(async_minimum, fastapi_testclient):
     response = fastapi_testclient.put(
         '/tasks',
         json=modified_task.dict(),
-        allow_redirects=True,
+        follow_redirects=True,
         headers=headers4ptest_one
     )
     assert response.status_code == status.HTTP_403_FORBIDDEN