Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/treepublisher handle empty set #287

Merged

Conversation

kjsanger
Copy link
Member

@kjsanger kjsanger commented Sep 1, 2020

No description provided.

@kjsanger kjsanger added bug bump minor Bump the minor version on release labels Sep 1, 2020
@kjsanger kjsanger requested a review from mgcam September 2, 2020 08:46
Copy link
Member

@mgcam mgcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with real data against a devel iRODS server, suggested a few minor improvements

Handle --exclude arguments, rather than ignore them.

Handle errors in regex arguments nicely, reporting any errors and
explanations to the user.

Fix omissions and typos in POD.
@kjsanger kjsanger force-pushed the bugfix/treepublisher-handle-empty-set branch from 9a1f358 to af60e8c Compare September 2, 2020 10:35
@mgcam
Copy link
Member

mgcam commented Sep 2, 2020

All minor problems now, merging

@mgcam mgcam merged commit 76f97cf into wtsi-npg:devel Sep 2, 2020
@kjsanger kjsanger deleted the bugfix/treepublisher-handle-empty-set branch November 9, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bump minor Bump the minor version on release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants