-
-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make github a multisource widget #450
Make github a multisource widget #450
Conversation
Note, that this is a backwards incompatible change Previous config: ``` repositories: wtf: "wtfutil" ``` New Config: ``` repositories: - "wtfutil/wtf" ```
d518353
to
c35034d
Compare
It doesn't have to be backwards incompatible. There's already an established precedent for changing config types. See how In this case you'd first try to cast to |
Thanks! Will take a look |
There is one major difference here in that MultiSourceWidget expects a specific config type to get the sources. |
I'm not sure what you mean. It looks like Multisource reads the |
Parse repositories both ways Have github manually set sources, since historical config may not handle
You are correct, I am now handling both configs and works fine by setting Sources manually in construction. |
Thanks! |
Note, that this is a backwards incompatible change
Previous config:
New Config: