Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak deprecation to clarify change #217

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Tweak deprecation to clarify change #217

merged 1 commit into from
Apr 16, 2024

Conversation

wspurgin
Copy link
Owner

Add silencing capability

@wspurgin
Tweak deprecation to clarify change
2eead07 
Add silencing capability
@wspurgin wspurgin marked this pull request as ready for review April 15, 2024 15:52
@wspurgin wspurgin mentioned this pull request Apr 15, 2024
Merged
@3v0k4
Copy link
Contributor

3v0k4 commented Apr 15, 2024 •
edited
Loading

I'm wondering if a "find and replace all" in any IDE or the appropriate sed command in the changelog or deprecation message would suffice instead of adding code and a wiki page that both need to be maintained 🙂

@wspurgin
Copy link
Owner Author

wspurgin commented Apr 16, 2024 •
edited
Loading

Wiki pages are not that much maintenance, and I'd rather over-communicate 😄

@wspurgin wspurgin merged commit d24cc9e into main Apr 16, 2024
21 checks passed
@wspurgin wspurgin deleted the ws/tweak-message-and-add-silence-capability branch April 16, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wspurgin @3v0k4