Update failure message to list out actual jobs line-by-line #195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help in issues like #162 and #168 where the previous description made it harder to tell that the actual was an array of jobs with arguments, not a single job with a single array arg.
New description would look like:
Closes #162
Closes #168
Also, it nests the "context" under each Job as well (formerly was "options" in the failure message - it's called the job hash "context" in Sidekiq, so I'm updating to use that terminology to be consistent).
The previous failure message only ever showed
"at"
, but I've elected to include the full job context without args in the output. I'm doing that to pave the way for a generalwith_context
(not tied to the name) matcher to tests things like "retry" and "queue" too.As an example, if we added the
in
matcher: