Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Sidekiq 7 #192

Merged
merged 9 commits into from
Jul 23, 2023
Merged

Support Sidekiq 7 #192

merged 9 commits into from
Jul 23, 2023

Conversation

wspurgin
Copy link
Owner

@wspurgin wspurgin commented Jul 23, 2023 •
edited
Loading

Closes #191

  1. Support through Sidekiq 7
  2. Drops support for Sidekiq <5
  3. Deprecates be_delayed

Misc.

  • Update licenses to reflect new ownership (still MIT)

@wspurgin
Fix specs for Sidekiq 7
480935e 
Clarified changlog; removed be_delayed from README

Revert "Clarified changlog; removed be_delayed from README"

This reverts commit a32389c4a0141f22581010645e8ceb00180e0ec2.

Revert "Support Sidekiq 7"

This reverts commit c464e13ee1960318d5a68ce1595517f7b15a4c75.

Support Sidekiq 7 in the dev environment
@wspurgin
🤏 Missed it by that much
7ce2fc1
@wspurgin
Only skip _if_ it's Sidekiq 7+
4aac21e
@wspurgin
Raise error if using Sidekiq 7+ and be_delayed
ac70060
@wspurgin
Drop support for <5 Sidekiq
4afc00e
@wspurgin
Update LICENSE (still MIT) and gemspec
4307a7d
@wspurgin
Use Gem Version
a2896c9 
Comparing against a string is a Ruby 3.1+ feature 🤦‍♂️
@wspurgin
Update README for be_delayed deprecation
d9167ce
@wspurgin
🎨 segment out settings
be21d8a
@wspurgin wspurgin marked this pull request as ready for review July 23, 2023 22:25
@wspurgin wspurgin merged commit e62a9cd into develop Jul 23, 2023
28 checks passed
@wspurgin wspurgin deleted the ws/support-sidekiq-7 branch July 23, 2023 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Sidekiq 7 and deprecate be_delayed matcher
1 participant
@wspurgin