Provide first class support for essential request and response properties #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ties Provide first class support for essential request and response properties in carbon message
riyafa
reviewed
May 27, 2019
| if (value == null) { | ||
| return defaultValue; | ||
| return 200; |
chamil321
reviewed
May 27, 2019
| @@ -89,7 +89,7 @@ public DefaultHttpClientConnector(ConnectionManager connectionManager, SenderCon | |||
| this.http2ConnectionManager = connectionManager.getHttp2ConnectionManager(); | |||
| this.senderConfiguration = senderConfiguration; | |||
| initTargetChannelProperties(senderConfiguration); | |||
| if (Float.valueOf(senderConfiguration.getHttpVersion()) == Constants.HTTP_2_0) { | |||
| if (senderConfiguration.getHttpVersion().equals(Constants.HTTP_2_0)) { | |||
There was a problem hiding this comment.
Suggested change
| if (senderConfiguration.getHttpVersion().equals(Constants.HTTP_2_0)) { | |
| if (Constants.HTTP_2_0.equals(senderConfiguration.getHttpVersion())) { |
| @@ -95,11 +95,11 @@ public static void writeRequestHeaders(HttpCarbonMessage httpOutboundRequest, | |||
| } | |||
|
|
|||
| private static void setHttpVersionProperty(HttpCarbonMessage httpOutboundRequest, String httpVersion) { | |||
| if (Float.valueOf(httpVersion) == Constants.HTTP_2_0) { | |||
| if (httpVersion.equals(Constants.HTTP_2_0)) { | |||
There was a problem hiding this comment.
Suggested change
| if (httpVersion.equals(Constants.HTTP_2_0)) { | |
| if (Constants.HTTP_2_0.equals(httpVersion)) { |
| @@ -95,7 +95,7 @@ public HttpClientChannelInitializer(SenderConfiguration senderConfiguration, Htt | |||
| this.connectionAvailabilityFuture = connectionAvailabilityFuture; | |||
|
|
|||
| String httpVersion = senderConfiguration.getHttpVersion(); | |||
| if (Float.valueOf(httpVersion) == Constants.HTTP_2_0) { | |||
| if (httpVersion.equals(Constants.HTTP_2_0)) { | |||
There was a problem hiding this comment.
Suggested change
| if (httpVersion.equals(Constants.HTTP_2_0)) { | |
| if (Constants.HTTP_2_0.equals(httpVersion)) { |
shafreenAnfar
approved these changes
Jun 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Provide first class support for essential request and response properties in carbon message
Goals
Fix the issue : ballerina-platform/ballerina-lang#14953