Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react): fix padding issue in TextField #295

Merged
merged 5 commits into from
Oct 23, 2024
Merged

fix(react): fix padding issue in TextField #295

merged 5 commits into from
Oct 23, 2024

Conversation

brionmario
Copy link
Member

@brionmario brionmario commented Oct 23, 2024 •
edited
Loading

Purpose

There was an additional padding getting applied to TextField when multiline was used.

Screenshot 2024-10-23 at 09 18 49

Related Issues

Related PRs

  • N/A

Checklist

  • Figma Board Updated. (Mandatory for Icon and Component PRs. If you don't have access, please ask the core team to update it.)
  • UX/UI review done on the final implementation.
  • Story provided. (Add screenshots)
  • Manual test round performed and verified.
  • Unit tests provided. (Add links if there are any)
  • Documentation provided. (Add links if there are any)

Security checks

@brionmario brionmario force-pushed the migrate-default-props branch from 04699e4 to 22df251 Compare October 23, 2024 04:10
@brionmario brionmario force-pushed the migrate-default-props branch from 22df251 to ab542a2 Compare October 23, 2024 04:11
dasuni-30
dasuni-30 previously approved these changes Oct 23, 2024
View reviewed changes
JayaShakthi97
JayaShakthi97 previously approved these changes Oct 23, 2024
View reviewed changes
@brionmario brionmario dismissed stale reviews from JayaShakthi97 and dasuni-30 via 046963d October 23, 2024 04:37
@brionmario brionmario merged commit e7bf716 into wso2:main Oct 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JayaShakthi97 JayaShakthi97 JayaShakthi97 approved these changes

@dasuni-30 dasuni-30 dasuni-30 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@brionmario @dasuni-30 @JayaShakthi97