fix(react): fix component composition issues #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brionmario
changed the title
defaultProps
brionmario
force-pushed
the
migrate-default-props
branch
from
9375113 to
c180abf
Compare
brionmario
commented
Oct 11, 2024
| /** | ||
| * @deprecated Use the {@link CountryFlagProps} instead. | ||
| */ | ||
| export type CountryFlagsProps = CountryFlagProps; |
There was a problem hiding this comment.
Deprecation tracker: #285 (comment)
pavinduLakshan
previously approved these changes
Oct 11, 2024
savindi7
reviewed
Oct 11, 2024
pavinduLakshan
previously approved these changes
Oct 11, 2024
pavinduLakshan
previously approved these changes
Oct 11, 2024
savindi7
reviewed
Oct 11, 2024
savindi7
reviewed
Oct 11, 2024
brionmario
force-pushed
the
migrate-default-props
branch
from
824580c to
262b1c9
Compare
pavinduLakshan
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
In this PR:
defaultPropson functional components and refactored to use ES6 syntax. (See: Warn when Using DefaultProps on Function Components facebook/react#16210)componentprop.Related Issues
defaultPropssince it'll be deprecated in the future #277Related PRs
Checklist
Security checks