fix(react): remove hardcoded values in chip and autocomplete. #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavinduLakshan
previously approved these changes
Nov 21, 2023
pavinduLakshan
dismissed
their stale review
Commit message doesn't adhere to the recommended format
Achintha444
changed the title
Achintha444
changed the title
chore(react): fix es lint issue
savindi7
reviewed
Dec 2, 2023
| font-size: 0.8125rem; | ||
| } | ||
|
|
||
| .MuiChip-sizeSmall { |
There was a problem hiding this comment.
Let's not use MUI's class names to change styles..
|
What is the status of this PR? |
brionmario
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix Details
font-sizeandheightto the chips in the autocomplete.Related Issues
Checklist
Security checks