Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react): add Autocomplete component #165

Merged
merged 11 commits into from
Oct 16, 2023
Merged

feat(react): add Autocomplete component #165

merged 11 commits into from
Oct 16, 2023

Conversation

Achintha444
Copy link
Contributor

Purpose

Wrap Autocomplete component from MUI.

Related Issues

Checklist

  • UX/UI review done on the final implementation.
  • Story provided. (Add screenshots)
  • Manual test round performed and verified.
  • Unit tests provided. (Add links if there are any)
  • Documentation provided. (Add links if there are any)

Security checks

@Achintha444 Achintha444 mentioned this pull request Oct 5, 2023
Open
73 tasks
@Achintha444 Achintha444 mentioned this pull request Oct 6, 2023
Closed
savindi7
savindi7 previously approved these changes Oct 6, 2023
View reviewed changes
@savindi7 savindi7 self-requested a review October 6, 2023 04:23
@savindi7
Copy link
Contributor

savindi7 commented Oct 6, 2023

@Achintha444
Wrap Autocomplete component from MUI. this commit message needs to follow the guidelines

brionmario
brionmario previously approved these changes Oct 6, 2023
View reviewed changes
savindi7
savindi7 previously approved these changes Oct 6, 2023
View reviewed changes
@Achintha444 Achintha444 dismissed stale reviews from savindi7 and brionmario via 8e8fc1b October 8, 2023 15:57
pavinduLakshan
pavinduLakshan reviewed Oct 8, 2023
View reviewed changes
Copy link
Contributor

@pavinduLakshan pavinduLakshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not use All Rights Reserved phrase for open source code licensed under apache license.

packages/react/src/components/Autocomplete/Autocomplete.stories.mdx Show resolved Hide resolved
packages/react/src/components/Autocomplete/Autocomplete.tsx Show resolved Hide resolved
packages/react/src/components/Autocomplete/__tests__/Autocomplete.test.tsx Show resolved Hide resolved
packages/react/src/components/Autocomplete/autocomplete.scss Show resolved Hide resolved
packages/react/src/components/Autocomplete/index.ts Show resolved Hide resolved
jeradrutnam
jeradrutnam reviewed Oct 9, 2023
View reviewed changes
packages/react/.storybook/story-config.ts
@@ -43,6 +43,7 @@ export type Stories =
| 'AlertTitle'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file will get removed. Fine to keep it for now.

@Achintha444 Achintha444 mentioned this pull request Oct 13, 2023
Merged
9 tasks
@Achintha444 Achintha444 merged commit 4aeb035 into wso2:main Oct 16, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavinduLakshan pavinduLakshan pavinduLakshan left review comments

@jeradrutnam jeradrutnam jeradrutnam left review comments

@savindi7 savindi7 savindi7 approved these changes

@brionmario brionmario brionmario left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Achintha444 @savindi7 @jeradrutnam @brionmario @pavinduLakshan