Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v5.10.x] Add Input Option to Set Ingress Class and Annotations #259

Merged
merged 2 commits into from
Aug 20, 2020
Merged

[v5.10.x] Add Input Option to Set Ingress Class and Annotations #259

merged 2 commits into from
Aug 20, 2020

Conversation

chirangaalwis
Copy link
Member

Purpose

This PR performs $subject, thus closing the linked issue.

Goals

Add input option to set Ingress class and annotations

Test environment

Helm version: 3.2.4
GKE based Kubernetes Server version: 1.15+, Git Version: v1.15.12-gke.2
Product Docker images from WSO2 organization in DockerHub

@chirangaalwis chirangaalwis linked an issue Aug 20, 2020 that may be closed by this pull request
[v5.10.x] Add Input Option to Set Ingress Class and Annotations #257
Closed
@ThilinaManamgoda ThilinaManamgoda merged commit 068965a into wso2:5.10.x Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThilinaManamgoda ThilinaManamgoda ThilinaManamgoda approved these changes

@DilanUA DilanUA Awaiting requested review from DilanUA

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[v5.10.x] Add Input Option to Set Ingress Class and Annotations
2 participants
@chirangaalwis @ThilinaManamgoda