Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the obsolete logic of resolving the authenticated username of organization SSO users #114

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Remove the obsolete logic of resolving the authenticated username of organization SSO users #114

merged 1 commit into from
Nov 15, 2023

Conversation

sadilchamishka
Copy link
Contributor

@sadilchamishka sadilchamishka commented Nov 15, 2023 •
edited
Loading

Purpose

With this PR wso2-extensions/identity-carbon-auth-rest#254 the correct username is set in the carbon context at the authentication valve level. Hence these type of logics are no more required.

Related Issues

Depends on

@sadilchamishka sadilchamishka mentioned this pull request Nov 15, 2023
Merged
@sadilchamishka sadilchamishka force-pushed the remove-obsolete-code branch 2 times, most recently from 5b04cc4 to 88c5677 Compare November 15, 2023 01:55
dewniMW
dewniMW previously approved these changes Nov 15, 2023
View reviewed changes
@sadilchamishka sadilchamishka merged commit ec208d2 into wso2:main Nov 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dewniMW dewniMW dewniMW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sadilchamishka @dewniMW