Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trusted app configs getting cleared issue #6751

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

ImalshaG
Copy link
Contributor

Purpose

If FIDO trusted apps feature is disabled, set each property inside trusted app metadata as empty and set isFIDOtrusted app attribute to false instead of setting the whole trusted app metadata object to null.

This is done to resolve the issue of trusted app data getting cleared when the General or protocol tab is updated. This is happening because during such patch calls, the rest of the application advanced configuration attributes will be set as null except for the needed attribute, and therefore the trusted app metadata will be removed from the DB.

Related Issues

wso2/product-is#20882

Related PRs

#6553

Checklist

  • e2e cypress tests locally verified. (for internal contributers)
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Relevant backend changes deployed and verified
  • Unit tests provided. (Add links if there are any)

Security checks

@wso2-jenkins-bot
Copy link
Contributor

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@ImalshaG ImalshaG merged commit bc73ba3 into wso2:master Aug 12, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants