Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade console and my account to React Router v6 #6397

Closed

Conversation

pavinduLakshan
Copy link
Contributor

Purpose

$subject

Related Issues

  • N/A

Related PRs

  • N/A

Checklist

  • e2e cypress tests locally verified.
  • Manual test round performed and verified.
  • UX/UI review done on the final implementation.
  • Documentation provided. (Add links if there are any)
  • Unit tests provided. (Add links if there are any)
  • Integration tests provided. (Add links if there are any)

Security checks

@pavinduLakshan pavinduLakshan marked this pull request as draft June 3, 2024 17:37
@pavinduLakshan
Copy link
Contributor Author

Kept in draft state since the console refactoring is still going on.

@pavinduLakshan
Copy link
Contributor Author

Unfortunately, there is no standard way to navigate outside react components since in v6, the direct use of history object is discouraged and react router also doesn't provide a way to implement this functionality[1].

This severely affect migrating our console app to v6, since the features use a shared history and now that is no longer possible out-of-the-box in RRV6 it seems :(.

[1] remix-run/react-router#9422

@pavinduLakshan pavinduLakshan added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jun 5, 2024
@pavinduLakshan pavinduLakshan force-pushed the upgrade_to_react_router_6 branch from 90ec1ef to 4bf56b3 Compare June 5, 2024 11:00
@wso2-jenkins-bot
Copy link
Contributor

⚠️ No Changeset found

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.

If these changes should result in a version bump, you need to add a changeset.

Refer Release Documentation to learn how to add a changeset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants