(improvement) Adding config for API Based Authn configuration #4885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Api based authn asgardeo
brionmario
reviewed
Nov 30, 2023
| @@ -305,6 +305,7 @@ export const AdvancedConfigurationsForm: FunctionComponent<AdvancedConfiguration | |||
| /> | |||
| { | |||
| ( | |||
| UIConfig?.showAPIBasedAuthentication && | |||
There was a problem hiding this comment.
IMO, we don't need a dedicate config for this.
This should go in to disabled features array of the Applications feature.
@Achintha444 FYI
There was a problem hiding this comment.
Ack, will make the necessary changes.
There was a problem hiding this comment.
Fixed with 2b56cd1
added 2 commits
December 1, 2023 10:24
brionmario
approved these changes
Dec 1, 2023
added 2 commits
December 1, 2023 13:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Conditionally render API_Based_Authentication, with following toml file
By default, its enabled but this can be disabled with following config
Related Issues
Related PRs
Checklist
Security checks