Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useClientIdAsSubClaimForAppTokens and omitUsernameInIntrospectionRespForAppTokens configs to app #644

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

mpmadhavig
Copy link
Contributor

@mpmadhavig mpmadhavig commented Aug 14, 2024

Proposed changes in this pull request

useClientIdAsSubClaimForAppTokens and omitUsernameInIntrospectionRespForAppTokens configs are being introduce to support the on the fly migration for client apps for the issue mentioned in [1].

The configs values will be default false for old apps, default true for new apps. Old app owners can do necessary changes and change the config value to true marking a successful migration.

[1] wso2/product-is#16060
[2]

Related Issues:

@CLAassistant
Copy link

CLAassistant commented Aug 21, 2024

CLA assistant check
All committers have signed the CLA.

@mpmadhavig mpmadhavig force-pushed the feature-enable-disable-config-api branch from 7c3bd18 to 3902a35 Compare August 21, 2024 11:21
@jenkins-is-staging
Copy link

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/10488912169
Status: failure

@mpmadhavig
Copy link
Contributor Author

PR builder completed Link: https://github.com/wso2/product-is/actions/runs/10488912169 Status: failure

The PR builder is failing due to not having proper DO to store response data. With wso2/product-is#20958 this will get fixed.

@mpmadhavig
Copy link
Contributor Author

PR builder completed Link: https://github.com/wso2/product-is/actions/runs/10488912169 Status: failure

The PR builder is failing due to not having proper DO to store response data. With wso2/product-is#20958 this will get fixed.

Locally build passed:
Screenshot 2024-08-22 at 09 13 51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants