fix possible NPEs

wso2 · Oct 23, 2023 · a997988 · a997988
1 parent 8423c4b
commit a997988
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/...erver/application/management/v1/core/functions/application/ServiceProviderToApiModel.java b/...erver/application/management/v1/core/functions/application/ServiceProviderToApiModel.java
@@ -51,6 +51,7 @@
 import org.wso2.carbon.identity.application.common.model.LocalAuthenticatorConfig;
 import org.wso2.carbon.identity.application.common.model.RequestPathAuthenticatorConfig;
 import org.wso2.carbon.identity.application.common.model.RoleMapping;
+import org.wso2.carbon.identity.application.common.model.RoleV2;
 import org.wso2.carbon.identity.application.common.model.ServiceProvider;
 import org.wso2.carbon.identity.application.common.model.ServiceProviderProperty;
 import org.wso2.carbon.identity.application.common.util.IdentityApplicationConstants;
@@ -139,7 +140,8 @@ private AssociatedRolesConfig buildAssociatedRoles(ServiceProvider application)
                 break;
         }
         associatedRolesConfig.setAllowedAudience(allowedAudienceEnum);
-        application.getAssociatedRolesConfig().getRoles().forEach(role -> associatedRolesConfig.addRolesItem(
+        RoleV2[] roles = application.getAssociatedRolesConfig().getRoles();
+        Arrays.asList(roles).forEach(role -> associatedRolesConfig.addRolesItem(
                 new Role().id(role.getId()).name(role.getName())));
         return associatedRolesConfig;
     }

diff --git a/...pi/server/application/management/v1/core/functions/application/UpdateAssociatedRoles.java b/...pi/server/application/management/v1/core/functions/application/UpdateAssociatedRoles.java
@@ -20,6 +20,7 @@
 
 import org.wso2.carbon.identity.api.server.application.management.v1.AssociatedRolesConfig;
 import org.wso2.carbon.identity.api.server.application.management.v1.core.functions.UpdateFunction;
+import org.wso2.carbon.identity.application.common.model.RoleV2;
 import org.wso2.carbon.identity.application.common.model.ServiceProvider;
 
 import java.util.List;
@@ -41,7 +42,7 @@ public void apply(ServiceProvider serviceProvider, AssociatedRolesConfig associa
                     associatedRolesConfig.getRoles().stream()
                             .map(role -> new org.wso2.carbon.identity.application.common.model.RoleV2(role.getId()))
                             .collect(Collectors.toList());
-            rolesConfig.setRoles(listOfRoles);
+            rolesConfig.setRoles(listOfRoles.toArray(new RoleV2[0]));
         }
         serviceProvider.setAssociatedRolesConfig(rolesConfig);
     }

diff --git a/...pi/server/application/management/v1/core/functions/application/UpdateServiceProvider.java b/...pi/server/application/management/v1/core/functions/application/UpdateServiceProvider.java
@@ -50,7 +50,8 @@ public void apply(ServiceProvider serviceProvider, ApplicationPatchModel applica
         patchProvisioningConfiguration(applicationPatchModel.getProvisioningConfigurations(), serviceProvider);
     }
 
-    private void patchAssociatedRolesConfigurations(ServiceProvider serviceProvider, AssociatedRolesConfig associatedRoles) {
+    private void patchAssociatedRolesConfigurations(ServiceProvider serviceProvider,
+                                                    AssociatedRolesConfig associatedRoles) {
 
         if (associatedRoles != null) {
             new UpdateAssociatedRoles().apply(serviceProvider, associatedRoles);