Create complex object to store role properties #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #417 +/- ##
============================================
+ Coverage 28.40% 28.45% +0.04%
Complexity 919 919
============================================
Files 133 133
Lines 13007 13030 +23
Branches 2504 2504
============================================
+ Hits 3695 3708 +13
- Misses 8839 8849 +10
Partials 473 473
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ShanChathusanda93
force-pushed
the
role-prop-charon-branch
branch
2 times, most recently
from
1082ef9 to
8f4c235
Compare
2 tasks
| @@ -612,6 +619,11 @@ public static class RoleSchemaConstants { | |||
| public static final String AUDIENCE_DISPLAY_URI = | |||
| "urn:ietf:params:scim:schemas:extension:2.0:Role:audience.display"; | |||
| public static final String AUDIENCE_TYPE_URI = "urn:ietf:params:scim:schemas:extension:2.0:Role:audience.type"; | |||
| public static final String ROLE_PROPERTY_NAME_URI = | |||
| "urn:ietf:params:scim:schemas:extension:2.0:Role:roleProperties.name"; | |||
There was a problem hiding this comment.
Suggested change
| "urn:ietf:params:scim:schemas:extension:2.0:Role:roleProperties.name"; | |
| "urn:ietf:params:scim:schemas:extension:2.0:Role:properties.name"; |
| @@ -612,6 +619,11 @@ public static class RoleSchemaConstants { | |||
| public static final String AUDIENCE_DISPLAY_URI = | |||
| "urn:ietf:params:scim:schemas:extension:2.0:Role:audience.display"; | |||
| public static final String AUDIENCE_TYPE_URI = "urn:ietf:params:scim:schemas:extension:2.0:Role:audience.type"; | |||
| public static final String ROLE_PROPERTY_NAME_URI = | |||
There was a problem hiding this comment.
Suggested change
| public static final String ROLE_PROPERTY_NAME_URI = | |
| public static final String PROPERTIES_NAME_URI = |
| @@ -550,6 +550,10 @@ public static class RoleSchemaConstants { | |||
| public static final String DISPLAY = "display"; | |||
| public static final String VALUE = "value"; | |||
| public static final String TYPE = "type"; | |||
| public static final String ROLE_PROPERTIES_URI = | |||
| "urn:ietf:params:scim:schemas:extension:2.0:Role:roleProperties"; | |||
| public static final String ROLE_PROPERTIES = "roleProperties"; | |||
There was a problem hiding this comment.
Suggested change
| public static final String ROLE_PROPERTIES = "roleProperties"; | |
| public static final String PROPERTIES = "roleProperties"; |
| SCIMConstants.RoleSchemaConstants.ROLE_PROPERTY_NAME, SCIMDefinitions.DataType.STRING, false, | ||
| SCIMConstants.RoleSchemaConstants.ROLE_PROPERTY_NAME_DESC, false, false, | ||
| SCIMDefinitions.Mutability.IMMUTABLE, SCIMDefinitions.Returned.DEFAULT, | ||
| SCIMDefinitions.Uniqueness.NONE, null, null, null); |
There was a problem hiding this comment.
Name needs to be unique
ShanChathusanda93
force-pushed
the
role-prop-charon-branch
branch
4 times, most recently
from
5b11bd6 to
eb501c2
Compare
ShanChathusanda93
force-pushed
the
role-prop-charon-branch
branch
from
eb501c2 to
fbdb315
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose