Cursor based pagination for SCIM resources effort 2 #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pagination capability
Cursor pagination changes - phase 1 formatting adjustments before PR more formatting adjustments and removing unneccesary comments Formatting the code Adjustments made to Cursor Pagination for SCIM resources Changes made as per the code review Changing the response type from a List to UsersGetResponse type object Changing the response type from a List to UsersGetResponse type object - changes based on the code review formatting changes Made changes to support POST/.Search cursor pagination Made changes so that the ServiceProviderConfig endpoint shows cursor pagination capability minor changes Fix for NullPointerException when running UserResourceManagerTest Updated wording for serviceProviderConfigEndpoint changes Formatting changes Removing unused parameters from processPagination method Updating tests broken due to changes and writing new tests for cursor pagination formatting
|
|
There was a problem hiding this comment.
Copilot reviewed 5 out of 18 changed files in this pull request and generated no suggestions.
Files not reviewed (13)
- modules/charon-core/src/main/java/org/wso2/charon3/core/protocol/endpoints/ResourceManager.java: Evaluated as low risk
- modules/charon-core/src/test/java/org/wso2/charon3/core/protocol/endpoints/UserResourceManagerTest.java: Evaluated as low risk
- modules/charon-core/src/main/java/org/wso2/charon3/core/utils/codeutils/SearchRequest.java: Evaluated as low risk
- modules/charon-core/src/main/java/org/wso2/charon3/core/utils/ResourceManagerUtil.java: Evaluated as low risk
- modules/charon-core/src/main/java/org/wso2/charon3/core/protocol/SCIMResponse.java: Evaluated as low risk
- modules/charon-utils/src/main/java/org/wso2/charon3/utils/usermanager/InMemoryUserManager.java: Evaluated as low risk
- modules/charon-core/src/main/java/org/wso2/charon3/core/config/CharonConfiguration.java: Evaluated as low risk
- modules/charon-core/src/main/java/org/wso2/charon3/core/objects/ListedResource.java: Evaluated as low risk
- modules/charon-core/src/main/java/org/wso2/charon3/core/objects/plainobjects/UsersGetResponse.java: Evaluated as low risk
- modules/charon-core/src/main/java/org/wso2/charon3/core/extensions/UserManager.java: Evaluated as low risk
- modules/charon-core/src/main/java/org/wso2/charon3/core/encoder/JSONEncoder.java: Evaluated as low risk
- modules/charon-core/src/main/java/org/wso2/charon3/core/encoder/JSONDecoder.java: Evaluated as low risk
- modules/charon-core/src/main/java/org/wso2/charon3/core/config/SCIMConfigConstants.java: Evaluated as low risk
Comments skipped due to low confidence (2)
modules/charon-core/src/main/java/org/wso2/charon3/core/protocol/endpoints/UserResourceManager.java:396
- [nitpick] The word 'Pagination' should be consistently capitalized as 'pagination' in comments.
* @param cursorString Cursor value for pagination.
modules/charon-core/src/main/java/org/wso2/charon3/core/protocol/endpoints/UserResourceManager.java:406
- Ensure that the new cursor-based pagination functionality is covered by tests.
public SCIMResponse listWithGET(UserManager userManager, String filter, String cursorString, Integer countInt,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The purpose of this PR is to get the initial phase of cursor pagination for SCIM resource listings working with the Identity Server in JDBC and LDAP user stores.
Goals
Related Issues
Related PRs