Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the null pointer for operation json list. #406

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix the null pointer for operation json list. #406

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
43a6538
Fix the null pointer for operation json list.
Malith-19 Jul 1, 2024
14c2ca2
Format the code.
Malith-19 Jul 1, 2024
baa9ec4
Update the comments.
Malith-19 Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions modules/charon-core/src/main/java/org/wso2/charon3/core/encoder/JSONDecoder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,6 +753,18 @@ public ArrayList<PatchOperation> decodeRequest(String scimResourceString) throws
JSONObject decodedJsonObj = new JSONObject(new JSONTokener(scimResourceString));
//obtain the Operations values
JSONArray operationJsonList = (JSONArray) decodedJsonObj.opt(SCIMConstants.OperationalConstants.OPERATIONS);

//check if operationJsonList is null
if (operationJsonList == null) {

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove new lines Line 759, 764

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by 14c2ca2

//check if operations field present in lowercase
if (decodedJsonObj.has(StringUtils.lowerCase(SCIMConstants.OperationalConstants.OPERATIONS))) {
throw new BadRequestException("Invalid JSON schema.", ResponseCodeConstants.INVALID_SYNTAX);
}

throw new BadRequestException(ResponseCodeConstants.INVALID_SYNTAX);
}

//for each operation, create a PatchOperation object and add the relevant values to it
for (int count = 0; count < operationJsonList.length(); count++) {
JSONObject operation = (JSONObject) operationJsonList.get(count);
Expand Down
Loading