-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cursor based pagination for SCIM resources phase 1 #368
base: master
Are you sure you want to change the base?
Cursor based pagination for SCIM resources phase 1 #368
Conversation
.../charon-core/src/main/java/org/wso2/charon3/core/protocol/endpoints/UserResourceManager.java
Show resolved
Hide resolved
.../charon-core/src/main/java/org/wso2/charon3/core/protocol/endpoints/UserResourceManager.java
Outdated
Show resolved
Hide resolved
.../charon-core/src/main/java/org/wso2/charon3/core/protocol/endpoints/UserResourceManager.java
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/objects/ListedResource.java
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/objects/ListedResource.java
Outdated
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/objects/ListedResource.java
Outdated
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/objects/plainobjects/Cursor.java
Outdated
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/protocol/endpoints/ResourceManager.java
Outdated
Show resolved
Hide resolved
.../charon-core/src/main/java/org/wso2/charon3/core/protocol/endpoints/UserResourceManager.java
Outdated
Show resolved
Hide resolved
.../charon-core/src/main/java/org/wso2/charon3/core/protocol/endpoints/UserResourceManager.java
Outdated
Show resolved
Hide resolved
.../charon-core/src/main/java/org/wso2/charon3/core/protocol/endpoints/UserResourceManager.java
Outdated
Show resolved
Hide resolved
.../charon-core/src/main/java/org/wso2/charon3/core/protocol/endpoints/UserResourceManager.java
Outdated
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/utils/ResourceManagerUtil.java
Outdated
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/extensions/UserManager.java
Outdated
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/objects/plainobjects/Cursor.java
Outdated
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/protocol/SCIMResponse.java
Show resolved
Hide resolved
.../charon-core/src/main/java/org/wso2/charon3/core/protocol/endpoints/UserResourceManager.java
Outdated
Show resolved
Hide resolved
.../charon-core/src/main/java/org/wso2/charon3/core/protocol/endpoints/UserResourceManager.java
Outdated
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/objects/ListedResource.java
Outdated
Show resolved
Hide resolved
.../charon-core/src/main/java/org/wso2/charon3/core/protocol/endpoints/UserResourceManager.java
Outdated
Show resolved
Hide resolved
.../charon-core/src/main/java/org/wso2/charon3/core/protocol/endpoints/UserResourceManager.java
Outdated
Show resolved
Hide resolved
.../charon-core/src/main/java/org/wso2/charon3/core/protocol/endpoints/UserResourceManager.java
Outdated
Show resolved
Hide resolved
.../charon-core/src/main/java/org/wso2/charon3/core/protocol/endpoints/UserResourceManager.java
Outdated
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/utils/ResourceManagerUtil.java
Outdated
Show resolved
Hide resolved
.../charon-core/src/main/java/org/wso2/charon3/core/protocol/endpoints/UserResourceManager.java
Outdated
Show resolved
Hide resolved
...s/charon-core/src/main/java/org/wso2/charon3/core/objects/plainobjects/UsersGetResponse.java
Outdated
Show resolved
Hide resolved
...s/charon-core/src/main/java/org/wso2/charon3/core/objects/plainobjects/UsersGetResponse.java
Show resolved
Hide resolved
...s/charon-core/src/main/java/org/wso2/charon3/core/objects/plainobjects/UsersGetResponse.java
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/objects/plainobjects/Cursor.java
Outdated
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/objects/plainobjects/Cursor.java
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/objects/plainobjects/Cursor.java
Show resolved
Hide resolved
modules/charon-core/src/main/java/org/wso2/charon3/core/extensions/UserManager.java
Outdated
Show resolved
Hide resolved
...s/charon-core/src/main/java/org/wso2/charon3/core/objects/plainobjects/UsersGetResponse.java
Outdated
Show resolved
Hide resolved
modules/charon-utils/src/main/java/org/wso2/charon3/utils/usermanager/InMemoryUserManager.java
Outdated
Show resolved
Hide resolved
.../charon-core/src/main/java/org/wso2/charon3/core/protocol/endpoints/UserResourceManager.java
Outdated
Show resolved
Hide resolved
@@ -1004,7 +1005,7 @@ public void testListWithPOST(String resourceString, List<Object> tempList) | |||
|
|||
abstractResourceManager.when(() -> AbstractResourceManager.getResourceEndpointURL(SCIMConstants.USER_ENDPOINT)) | |||
.thenReturn(SCIM2_USER_ENDPOINT + "/.search"); | |||
Mockito.when(userManager.listUsersWithPost(any(SearchRequest.class), anyMap())).thenReturn(tempList); | |||
Mockito.when(userManager.listUsersWithPost(any(SearchRequest.class), anyMap())).thenReturn((UsersGetResponse) tempList); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recheck what is happening here.
modules/charon-core/src/main/java/org/wso2/charon3/core/objects/ListedResource.java
Show resolved
Hide resolved
Cursor pagination changes - phase 1 formatting adjustments before PR more formatting adjustments and removing unneccesary comments Formatting the code Adjustments made to Cursor Pagination for SCIM resources Changes made as per the code review Changing the response type from a List to UsersGetResponse type object Changing the response type from a List to UsersGetResponse type object - changes based on the code review formatting changes Made changes to support POST/.Search cursor pagination Made changes so that the ServiceProviderConfig endpoint shows cursor pagination capability minor changes Fix for NullPointerException when running UserResourceManagerTest Updated wording for serviceProviderConfigEndpoint changes Formatting changes Removing unused parameters from processPagination method Updating tests broken due to changes and writing new tests for cursor pagination formatting
fae4b2d
to
fe816b8
Compare
Closing this PR for now as it's been open for more than 14 days. Will reopen and merge soon |
|
Purpose
The purpose of this PR is to get the initial phase of cursor pagination for SCIM resource listings working with the Identity Server in JDBC and LDAP user stores.
Goals
Related Issues
Related PRs
Test environment