Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get role count for a filter in a given tenant #6190

Merged
merged 5 commits into from
Dec 11, 2024

Conversation

mpmadhavig
Copy link
Contributor

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 26.66667% with 44 lines in your changes missing coverage. Please review.

Project coverage is 45.41%. Comparing base (6224c1c) to head (3657daf).
Report is 188 commits behind head on master.

Files with missing lines Patch % Lines
...ty/role/v2/mgt/core/RoleManagementServiceImpl.java 0.00% 18 Missing ⚠️
...v2/mgt/core/RoleManagementEventPublisherProxy.java 0.00% 15 Missing ⚠️
...bon/identity/role/v2/mgt/core/dao/RoleDAOImpl.java 64.00% 5 Missing and 4 partials ⚠️
...e/v2/mgt/core/listener/RoleManagementListener.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6190      +/-   ##
============================================
- Coverage     45.42%   45.41%   -0.01%     
+ Complexity    14304    13938     -366     
============================================
  Files          1620     1620              
  Lines        104694   100509    -4185     
  Branches      17540    16689     -851     
============================================
- Hits          47555    45649    -1906     
+ Misses        50192    48116    -2076     
+ Partials       6947     6744     -203     
Flag Coverage Δ
unit 27.71% <26.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

return getFilteredRolesCount(expressionNodes, tenantDomain);
}

private int getFilteredRolesCount(List<ExpressionNode> expressionNodes, String tenantDomain)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to have this as a private method instead of having the logic inside getRolesCount method

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12253914782
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12253914782

@mpmadhavig mpmadhavig merged commit f0ab060 into wso2:master Dec 11, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants