-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add get role count for a filter in a given tenant #6190
Conversation
694758c
to
b9ca824
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6190 +/- ##
============================================
- Coverage 45.42% 45.41% -0.01%
+ Complexity 14304 13938 -366
============================================
Files 1620 1620
Lines 104694 100509 -4185
Branches 17540 16689 -851
============================================
- Hits 47555 45649 -1906
+ Misses 50192 48116 -2076
+ Partials 6947 6744 -203
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
PR builder started |
return getFilteredRolesCount(expressionNodes, tenantDomain); | ||
} | ||
|
||
private int getFilteredRolesCount(List<ExpressionNode> expressionNodes, String tenantDomain) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to have this as a private method instead of having the logic inside getRolesCount method
....core/src/main/java/org/wso2/carbon/identity/role/v2/mgt/core/RoleManagementServiceImpl.java
Outdated
Show resolved
Hide resolved
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12253914782
Quality Gate passedIssues Measures |
$subject
Related issue: