Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor application-mgt component to utilize certificate-mgt component for certificate management #6087

Merged
merged 23 commits into from
Nov 3, 2024

Conversation

ashanthamara
Copy link
Contributor

Proposed changes in this pull request

  • With this PR, application-mgt component will utilize certificate-mgt component for it's operations related to certificates and this will ensure that the application-mgt component will not perform any direct CRUD operations to the IDN_CERTIFICATE table.
  • Also removed the certificate validation at the ApplicationManagementService since that particular validation is checked in the the certificate-mgt component. Hence added necessary Client Exception checks to catch that in the ApplicationDAOImpl

Related Issue:

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 82.97872% with 16 lines in your changes missing coverage. Please review.

Project coverage is 40.57%. Comparing base (7f07a79) to head (116694b).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...y/application/mgt/dao/impl/ApplicationDAOImpl.java 89.28% 6 Missing and 3 partials ⚠️
...nternal/ApplicationManagementServiceComponent.java 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6087      +/-   ##
============================================
- Coverage     40.69%   40.57%   -0.13%     
- Complexity    14446    14515      +69     
============================================
  Files          1762     1763       +1     
  Lines        117627   118725    +1098     
  Branches      19025    19302     +277     
============================================
+ Hits          47868    48168     +300     
- Misses        62476    63213     +737     
- Partials       7283     7344      +61     
Flag Coverage Δ
unit 25.01% <82.97%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashanthamara ashanthamara marked this pull request as ready for review October 31, 2024 21:50
@jenkins-is-staging
Copy link

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11620418937
Status: failure

@jenkins-is-staging
Copy link

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11636749915
Status: failure

@jenkins-is-staging
Copy link

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11642804673
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11642804673

@jenkins-is-staging
Copy link

Copy link

sonarqubecloud bot commented Nov 2, 2024

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11645953009
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11645953009

@ashanthamara ashanthamara merged commit 8a2cbb2 into wso2:master Nov 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants