-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add certificate-mgt component to manage trusted certificates in IAM #6043
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6043 +/- ##
============================================
+ Coverage 40.07% 40.64% +0.57%
- Complexity 14324 14459 +135
============================================
Files 1746 1763 +17
Lines 118531 117790 -741
Branches 20474 19084 -1390
============================================
+ Hits 47501 47881 +380
+ Misses 63727 62618 -1109
+ Partials 7303 7291 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...a/org/wso2/carbon/identity/certificate/management/core/CertificateManagementServiceImpl.java
Outdated
Show resolved
Hide resolved
...a/org/wso2/carbon/identity/certificate/management/core/constant/CertificateMgtConstants.java
Outdated
Show resolved
Hide resolved
...a/org/wso2/carbon/identity/certificate/management/core/constant/CertificateMgtConstants.java
Outdated
Show resolved
Hide resolved
...so2/carbon/identity/certificate/management/core/ApplicationCertificateManagementService.java
Outdated
Show resolved
Hide resolved
...so2/carbon/identity/certificate/management/core/ApplicationCertificateManagementService.java
Outdated
Show resolved
Hide resolved
...carbon/identity/certificate/management/core/ApplicationCertificateManagementServiceImpl.java
Outdated
Show resolved
Hide resolved
...carbon/identity/certificate/management/core/ApplicationCertificateManagementServiceImpl.java
Outdated
Show resolved
Hide resolved
...carbon/identity/certificate/management/core/ApplicationCertificateManagementServiceImpl.java
Outdated
Show resolved
Hide resolved
.../java/org/wso2/carbon/identity/certificate/management/core/CertificateManagementService.java
Outdated
Show resolved
Hide resolved
...a/org/wso2/carbon/identity/certificate/management/core/CertificateManagementServiceImpl.java
Outdated
Show resolved
Hide resolved
...n/identity/certificate/management/core/dao/impl/ApplicationCertificateManagementDAOImpl.java
Outdated
Show resolved
Hide resolved
.../wso2/carbon/identity/certificate/management/core/dao/impl/CertificateManagementDAOImpl.java
Outdated
Show resolved
Hide resolved
.../main/java/org/wso2/carbon/identity/certificate/management/core/util/CertificateMgtUtil.java
Outdated
Show resolved
Hide resolved
...mgt/org.wso2.carbon.identity.certificate.management.core/src/test/resources/dbscripts/h2.sql
Outdated
Show resolved
Hide resolved
...mgt/org.wso2.carbon.identity.certificate.management.core/src/test/resources/dbscripts/h2.sql
Outdated
Show resolved
Hide resolved
...carbon/identity/certificate/management/core/ApplicationCertificateManagementServiceImpl.java
Outdated
Show resolved
Hide resolved
...ain/java/org/wso2/carbon/identity/certificate/management/core/util/CertificateValidator.java
Outdated
Show resolved
Hide resolved
...a/org/wso2/carbon/identity/certificate/management/core/CertificateManagementServiceImpl.java
Outdated
Show resolved
Hide resolved
...n/java/org/wso2/carbon/identity/certificate/management/CertificateManagementServiceImpl.java
Outdated
Show resolved
Hide resolved
...main/java/org/wso2/carbon/identity/certificate/management/constant/CertificateMgtErrors.java
Outdated
Show resolved
Hide resolved
...carbon/identity/certificate/management/dao/impl/CacheBackedApplicationCertificateMgtDAO.java
Show resolved
Hide resolved
...agement/src/main/java/org/wso2/carbon/identity/certificate/management/model/Certificate.java
Outdated
Show resolved
Hide resolved
.../carbon/identity/certificate/management/dao/ApplicationCertificateManagementDAOImplTest.java
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
* @deprecated It is recommended to use {@link CertificateManagementDAO}, which supports operations with UUID. | ||
*/ | ||
@Deprecated | ||
public interface ApplicationCertificateManagementDAO { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we add a new class as deprecated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To facilitate certificate management within the application-mgt component, a new certificate-mgt central component has been introduced. This design ensures that only the certificate-mgt component accesses the IDN_CERTIFICATE table, as discussed with @malithie , @darshanasbg , and @omindu. Separate classes were added for operations using integer IDs to avoid immediate data migration for existing entries in both the IDN_CERTIFICATE and SP_META_DATA tables (where certificate IDs are referenced).
These new classes have also been marked as deprecated to streamline their removal in the future. Additionally, there is a requirement to provide a REST API for certificate management where it gives a broader context to decide on the migration approach, allowing the deprecated classes to be phased out without doing data migration at this stage.
Proposed changes in this pull request
This PR will add the certificate-mgt component which will act as a central component for certificate handling.
Resolves: wso2/product-is#21377
Changes:
CertificateManagementService
for the certificate related operationsHence added a separate service(
ApplicationCertificateManagementService
) and DAO(ApplicationCertificateManagementDAO
) for the deprecated methods for more clarity.