-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add definedBy property for authenticators. #5990
Merged
Thisara-Welmilla
merged 2 commits into
wso2:add-definedBy-Type
from
Thisara-Welmilla:add-definedBy-type-prop
Oct 11, 2024
Merged
Add definedBy property for authenticators. #5990
Thisara-Welmilla
merged 2 commits into
wso2:add-definedBy-Type
from
Thisara-Welmilla:add-definedBy-type-prop
Oct 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thisara-Welmilla
force-pushed
the
add-definedBy-type-prop
branch
from
October 4, 2024 06:14
07cc31a
to
e80bd5c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## add-definedBy-Type #5990 +/- ##
========================================================
+ Coverage 39.67% 39.88% +0.21%
- Complexity 14218 14327 +109
========================================================
Files 1733 1735 +2
Lines 119164 120657 +1493
Branches 19755 20481 +726
========================================================
+ Hits 47278 48125 +847
- Misses 64666 65194 +528
- Partials 7220 7338 +118
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This was referenced Oct 4, 2024
malithie
reviewed
Oct 4, 2024
...ain/java/org/wso2/carbon/identity/application/common/model/FederatedAuthenticatorConfig.java
Outdated
Show resolved
Hide resolved
malithie
reviewed
Oct 4, 2024
...rc/main/java/org/wso2/carbon/identity/application/common/model/LocalAuthenticatorConfig.java
Outdated
Show resolved
Hide resolved
malithie
reviewed
Oct 4, 2024
...carbon/identity/application/authentication/framework/internal/FrameworkServiceComponent.java
Show resolved
Hide resolved
malithie
reviewed
Oct 4, 2024
...entity.base/src/main/java/org/wso2/carbon/identity/base/AuthenticatorPropertiesConstant.java
Outdated
Show resolved
Hide resolved
pamodaaw
reviewed
Oct 9, 2024
...ain/java/org/wso2/carbon/identity/application/common/model/FederatedAuthenticatorConfig.java
Outdated
Show resolved
Hide resolved
Thisara-Welmilla
force-pushed
the
add-definedBy-type-prop
branch
from
October 9, 2024 08:39
fe95d4b
to
5225998
Compare
Thisara-Welmilla
force-pushed
the
add-definedBy-type-prop
branch
from
October 9, 2024 08:59
5225998
to
eb2ca3b
Compare
malithie
approved these changes
Oct 11, 2024
Thisara-Welmilla
merged commit Oct 11, 2024
9ff18dd
into
wso2:add-definedBy-Type
3 of 4 checks passed
This was referenced Oct 14, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task Issue:
Related PRs:
With this following properties will be introduce to the authenticator configs and Application Authenticators.
DefinedBy
- to indicate whether the authenticator is system-defined or user-defined.With this PR following changes are added.