Fix previous validation error persist in static variable

[sadilchamishka]

$subject

The validation bean which keeps the errors shouldn't be a static variable, it should be an instance variable. But the way it has been implemented cause this issue.

Using instance variable from static methods are not allowed. Hence deprecated the below two static methods, and introduced new methods which are instance level.

• getCustomErrorMessagesWhenRegistering -> retrieveCustomErrorMessagesForRegistration
• getCustomErrorMessagesToVerifyCode -> getCustomErrorMessagesForCodeVerification

Related Issues

• Error response is mixed between different operations product-is#21169

[jenkins-is-staging]

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11101400781

[codecov]

Codecov Report

Attention: Patch coverage is 67.07317% with 27 lines in your changes missing coverage. Please review.

Project coverage is 23.55%. Comparing base (03355b8) to head (6ce866c).
Report is 43 commits behind head on master.

Files with missing lines	Patch %	Lines
.../identity/mgt/util/UserIdentityManagementUtil.java	74.60%	8 Missing and 8 partials ⚠️
...y/mgt/services/UserInformationRecoveryService.java	42.10%	11 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #5968      +/-   ##
============================================
+ Coverage     23.40%   23.55%   +0.14%     
- Complexity     6272     6324      +52     
============================================
  Files          1561     1561              
  Lines         99251    99326      +75     
  Branches      15190    15218      +28     
============================================
+ Hits          23232    23395     +163     
+ Misses        72751    72606     -145     
- Partials       3268     3325      +57     

Flag	Coverage Δ
unit	23.55% <67.07%> (+0.14%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jenkins-is-staging]

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11101400781
Status: success

[jenkins-is-staging]

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11101400781