Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce a config to update console & myaccount callback url & access url #5304

Merged
merged 4 commits into from
Dec 29, 2023
Merged

Introduce a config to update console & myaccount callback url & access url #5304

merged 4 commits into from
Dec 29, 2023

Conversation

UdeshAthukorala
Copy link
Contributor

@UdeshAthukorala UdeshAthukorala commented Dec 13, 2023 •
edited
Loading

Proposed changes in this pull request

  • Introduce a toml config to update console & myaccount callback url & access urls

    New Toml Configs

    [console]
callback_url = "https://localhost:9001/t/{TENANT_DOMAIN}/console"
access_url = "https://localhost:9001/t/{TENANT_DOMAIN}/console"

[myaccount]
callback_url = "https://localhost:9000/t/{TENANT_DOMAIN}/myaccount"
access_url = "https://localhost:9000/t/{TENANT_DOMAIN}/myaccount"

Related Issue

This was referenced Dec 13, 2023
Merged
Closed
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7212848577

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7212848577
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Dec 14, 2023
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/7212848577

@UdeshAthukorala UdeshAthukorala changed the title Introduce a config to update console & myaccount callback url Introduce a config to update console & myaccount callback url & access url Dec 15, 2023
Thisara-Welmilla
Thisara-Welmilla requested changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@Thisara-Welmilla Thisara-Welmilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we check the tenant_context.require_super_tenant_in_urls config and based on that add /t/carbon.super in path.

@UdeshAthukorala
Copy link
Contributor Author

Shall we check the tenant_context.require_super_tenant_in_urls config and based on that add /t/carbon.super in path.

Addressed with 7b8bd9e

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7295725652

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7295725652
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7356087987

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7356087987
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Dec 29, 2023
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/7356087987

@UdeshAthukorala UdeshAthukorala merged commit 43898f3 into wso2:master Dec 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madurangasiriwardena madurangasiriwardena madurangasiriwardena left review comments

@Thisara-Welmilla Thisara-Welmilla Thisara-Welmilla approved these changes

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@UdeshAthukorala @jenkins-is-staging @madurangasiriwardena @Thisara-Welmilla