Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the service URL builder logic for organization perspective access #5148

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Improve the service URL builder logic for organization perspective access #5148

merged 3 commits into from
Nov 15, 2023

Conversation

sadilchamishka
Copy link
Contributor

@sadilchamishka sadilchamishka commented Nov 10, 2023 •
edited
Loading

jenkins-is-staging
jenkins-is-staging approved these changes Nov 10, 2023
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6819613183

jenkins-is-staging
jenkins-is-staging approved these changes Nov 10, 2023
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6819614222

@sadilchamishka sadilchamishka force-pushed the improve-service-url-builder branch from 4cb0b97 to 2c66446 Compare November 11, 2023 03:36
@sadilchamishka sadilchamishka changed the title Imrpove the service URL builder logic & remove the organization context rewrites added for API paths Improve the service URL builder logic for organization perspective access Nov 11, 2023
@wso2 wso2 deleted a comment from jenkins-is-staging Nov 11, 2023
@wso2 wso2 deleted a comment from jenkins-is-staging Nov 11, 2023
@wso2 wso2 deleted a comment from jenkins-is-staging Nov 11, 2023
@wso2 wso2 deleted a comment from jenkins-is-staging Nov 11, 2023
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6831946198

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6831946457

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6831946198
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Nov 11, 2023
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6831946198

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6831946457
Status: failure

This was referenced Nov 15, 2023
Merged
Merged
@sadilchamishka sadilchamishka force-pushed the improve-service-url-builder branch from 2c66446 to 6919ed3 Compare November 15, 2023 05:24
@sadilchamishka sadilchamishka merged commit 6572ca8 into wso2:master Nov 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@dewniMW dewniMW dewniMW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sadilchamishka @jenkins-is-staging @dewniMW