Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support app audience role deletion on app deletion, Add Listeners for AssociatedRole config retrieval service, and Bug fixes #5047

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Support app audience role deletion on app deletion, Add Listeners for AssociatedRole config retrieval service, and Bug fixes #5047

merged 3 commits into from
Oct 24, 2023

Conversation

AnuradhaSK
Copy link
Contributor

@AnuradhaSK AnuradhaSK commented Oct 24, 2023 •
edited
Loading

Proposed changes in this pull request

  • Delete roles created with the application audience, when that application is deleted
  • Bug fixes:
    • Fix organization audience role creation validation
    • Change used DB connection in getHybridRolesByApplication() method
    • Fix allowedAudienceForAssociatedRoles value case sensitivity
    • Add listeners to get associated role retrieval of application service, and associating roles' allowed audience retrieval

Part of wso2/product-is#16363

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6624642211

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6624642211
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Oct 24, 2023
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6624642211

thanujalk
thanujalk previously approved these changes Oct 24, 2023
View reviewed changes
@AnuradhaSK AnuradhaSK changed the title Support app audience role deletion on app deletion and fix bugs Support app audience role deletion on app deletion, Add Listeners for AssociatedRole config retrieval service, and Bug fixes Oct 24, 2023
@AnuradhaSK AnuradhaSK mentioned this pull request Oct 24, 2023
Merged
1 task
@shashimalcse shashimalcse merged commit 86e2782 into wso2:master Oct 24, 2023
1 check passed
@AnuradhaSK AnuradhaSK deleted the delete-app-roles-on-appdelete branch October 24, 2023 14:37
@AnuradhaSK AnuradhaSK mentioned this pull request Oct 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@shashimalcse shashimalcse shashimalcse approved these changes

@thanujalk thanujalk thanujalk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnuradhaSK @jenkins-is-staging @thanujalk @shashimalcse