Introduce application role #4873
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.../src/main/java/org/wso2/carbon/identity/application/role/mgt/ApplicationRoleManagerImpl.java
Outdated
Show resolved
Hide resolved
...t/src/main/java/org/wso2/carbon/identity/application/role/mgt/dao/ApplicationRoleMgtDAO.java
Show resolved
Hide resolved
...n/java/org/wso2/carbon/identity/application/role/mgt/dao/impl/ApplicationRoleMgtDAOImpl.java
Outdated
Show resolved
Hide resolved
...n/java/org/wso2/carbon/identity/application/role/mgt/dao/impl/ApplicationRoleMgtDAOImpl.java
Outdated
Show resolved
Hide resolved
...n/java/org/wso2/carbon/identity/application/role/mgt/dao/impl/ApplicationRoleMgtDAOImpl.java
Show resolved
Hide resolved
...g/wso2/carbon/identity/application/role/mgt/internal/ApplicationRoleMgtServiceComponent.java
Show resolved
Hide resolved
...le.mgt/src/main/java/org/wso2/carbon/identity/application/role/mgt/util/GroupIDResolver.java
Outdated
Show resolved
Hide resolved
...le.mgt/src/main/java/org/wso2/carbon/identity/application/role/mgt/util/GroupIDResolver.java
Outdated
Show resolved
Hide resolved
| userStoreManager = getUserStoreManager(PrivilegedCarbonContext.getThreadLocalCarbonContext().getTenantId()); | ||
| return userStoreManager.isGroupExist(id); | ||
| } catch (UserStoreException e) { | ||
| throw new ApplicationRoleManagementServerException("Error occurred while retrieving the userstore manager " |
There was a problem hiding this comment.
We can move these to error message contants and use them right?
...on.role.mgt/src/main/java/org/wso2/carbon/identity/application/role/mgt/util/IDResolver.java
Outdated
Show resolved
Hide resolved
ThaminduR
reviewed
Sep 7, 2023
| <version>${maven.surefire.plugin.version}</version> | ||
| <configuration> | ||
| <argLine> | ||
| --add-opens java.xml/jdk.xml.internal=ALL-UNNAMED |
ThaminduR
reviewed
Sep 7, 2023
Comment on lines
95
to
101
| // Check whether new role name is already exists. | ||
| boolean existingRole = | ||
| applicationRoleMgtDAO.isExistingRole(applicationId, newName, tenantDomain); | ||
| if (existingRole) { | ||
| throw handleClientException(ERROR_CODE_DUPLICATE_ROLE, newName, | ||
| applicationId); | ||
| } |
There was a problem hiding this comment.
Can we refactor this into a private method since this is being used in several places? Basically to have a method to validate the roleName
ThaminduR
reviewed
Sep 7, 2023
| public ApplicationRole addApplicationRole(ApplicationRole applicationRole) | ||
| throws ApplicationRoleManagementException { | ||
|
|
||
| String tenantDomain = ApplicationRoleMgtUtils.getTenantDomain(); |
There was a problem hiding this comment.
Once role name validation is refactored into a private method, we won't need this variable.
ThaminduR
reviewed
Sep 7, 2023
| /** | ||
| * Cache implementation for application role cache. | ||
| */ | ||
| public class ApplicationRoleCache extends BaseCache<ApplicationRoleCacheKey, ApplicationRoleCacheEntry> { |
There was a problem hiding this comment.
Since this is Cache By Id, let's rename appropriately. Don't we need another cache impl for Cache by Name?
ThaminduR
reviewed
Sep 7, 2023
| /** | ||
| * Cache key to lookup application role from cache. | ||
| */ | ||
| public class ApplicationRoleCacheKey extends CacheKey { |
There was a problem hiding this comment.
Since this is cache key by role id, et's rename accordingly.
ThaminduR
reviewed
Sep 7, 2023
| SQLPlaceholders.DB_SCHEMA_COLUMN_NAME_ROLE_ID + "; AND SCOPE_NAME = :" + | ||
| SQLPlaceholders.DB_SCHEMA_COLUMN_NAME_SCOPE_NAME + "; AND TENANT_ID = :" + | ||
| SQLPlaceholders.DB_SCHEMA_COLUMN_NAME_TENANT_ID + ";"; | ||
| public static final String GET_APPLICATION_ROLE_BY_ID = "SELECT ROLE_ID, ROLE_NAME, TENANT_ID, APP_ID " + |
There was a problem hiding this comment.
Let's add a new line to keep the consistency. Check other places as well.
ThaminduR
reviewed
Sep 7, 2023
Comment on lines
132
to
133
| public static final String USER_ROLE_UNIQUE_CONSTRAINT = "user_role_unique"; | ||
| public static final String GROUP_ROLE_UNIQUE_CONSTRAINT = "group_role_unique"; |
There was a problem hiding this comment.
Can we move this to the top? or just before the inner class
Comment on lines
+48
to
+57
| private static final ApplicationRoleManager instance = new ApplicationRoleManagerImpl(); | ||
|
|
||
| private ApplicationRoleManagerImpl() { | ||
|
|
||
| } | ||
|
|
||
| public static ApplicationRoleManager getInstance() { | ||
|
|
||
| return instance; | ||
| } |
There was a problem hiding this comment.
Any reason for providing the singleton behaviour for this class. Normally these services are consumed by other modules by requesting the service objects via OSGI references. No harm, but just to know whether any practice
shashimalcse
changed the title
|
fixed via : wso2/product-is#16363 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
$subject
Related Issues