Merge pull request #6216 from Thisara-Welmilla/CUSTOM-to-Custom

Rename tag CUSTOM to Custom.
wso2 · Dec 18, 2024 · 71e2dd4 · 71e2dd4
2 parents 8960263 + 691edd7
commit 71e2dd4
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 7 deletions.
diff --git a/...so2/carbon/identity/application/common/model/UserDefinedFederatedAuthenticatorConfig.java b/...so2/carbon/identity/application/common/model/UserDefinedFederatedAuthenticatorConfig.java
@@ -20,13 +20,13 @@
 
 import org.wso2.carbon.identity.base.AuthenticatorPropertyConstants.DefinedByType;
 
+import static org.wso2.carbon.identity.base.AuthenticatorPropertyConstants.TAG_CUSTOM;
+
 /**
  * The user defined federated authenticator configuration model.
  */
 public class UserDefinedFederatedAuthenticatorConfig extends FederatedAuthenticatorConfig {
 
-    private static final String TAG_CUSTOM = "CUSTOM";
-
     private UserDefinedAuthenticatorEndpointConfig endpointConfig;
 
     public UserDefinedFederatedAuthenticatorConfig() {

diff --git a/...rg/wso2/carbon/identity/application/common/model/UserDefinedLocalAuthenticatorConfig.java b/...rg/wso2/carbon/identity/application/common/model/UserDefinedLocalAuthenticatorConfig.java
@@ -21,13 +21,14 @@
 import org.wso2.carbon.identity.base.AuthenticatorPropertyConstants.AuthenticationType;
 import org.wso2.carbon.identity.base.AuthenticatorPropertyConstants.DefinedByType;
 
+import static org.wso2.carbon.identity.base.AuthenticatorPropertyConstants.TAG_2FA;
+import static org.wso2.carbon.identity.base.AuthenticatorPropertyConstants.TAG_CUSTOM;
+
 /**
  * The user defined local authenticator configuration model.
  */
 public class UserDefinedLocalAuthenticatorConfig extends LocalAuthenticatorConfig {
 
-    private static final String TAG_2FA = "2FA";
-    private static final String TAG_CUSTOM = "CUSTOM";
     private AuthenticationType authenticationType;
     private UserDefinedAuthenticatorEndpointConfig endpointConfig;
 

diff --git a/.../org/wso2/carbon/identity/application/common/model/test/UserDefinedAuthenticatorTest.java b/.../org/wso2/carbon/identity/application/common/model/test/UserDefinedAuthenticatorTest.java
@@ -29,6 +29,8 @@
 import java.util.HashMap;
 
 import static org.testng.Assert.assertEquals;
+import static org.wso2.carbon.identity.base.AuthenticatorPropertyConstants.TAG_2FA;
+import static org.wso2.carbon.identity.base.AuthenticatorPropertyConstants.TAG_CUSTOM;
 
 public class UserDefinedAuthenticatorTest {
 
@@ -39,7 +41,7 @@ public void createUserDefinedLocalVerificationAuthenticator() {
 
         UserDefinedLocalAuthenticatorConfig config =
                 new UserDefinedLocalAuthenticatorConfig(AuthenticatorPropertyConstants.AuthenticationType.VERIFICATION);
-        assertEquals(config.getTags(), new String[]{"CUSTOM", "2FA"});
+        assertEquals(config.getTags(), new String[]{TAG_CUSTOM, TAG_2FA});
         assertEquals(config.getDefinedByType(), AuthenticatorPropertyConstants.DefinedByType.USER);
     }
 
@@ -49,15 +51,15 @@ public void createUserDefinedLocalIdentificationAuthenticator() {
         UserDefinedLocalAuthenticatorConfig config =
                 new UserDefinedLocalAuthenticatorConfig(
                         AuthenticatorPropertyConstants.AuthenticationType.IDENTIFICATION);
-        assertEquals(config.getTags(), new String[]{"CUSTOM"});
+        assertEquals(config.getTags(), new String[]{TAG_CUSTOM});
         assertEquals(config.getDefinedByType(), AuthenticatorPropertyConstants.DefinedByType.USER);
     }
 
     @Test
     public void createUserDefinedFederatedAuthenticator() {
 
         UserDefinedFederatedAuthenticatorConfig config = new UserDefinedFederatedAuthenticatorConfig();
-        assertEquals(config.getTags(), new String[]{"CUSTOM"});
+        assertEquals(config.getTags(), new String[]{TAG_CUSTOM});
         assertEquals(config.getDefinedByType(), AuthenticatorPropertyConstants.DefinedByType.USER);
     }
 

diff --git a/...tity.base/src/main/java/org/wso2/carbon/identity/base/AuthenticatorPropertyConstants.java b/...tity.base/src/main/java/org/wso2/carbon/identity/base/AuthenticatorPropertyConstants.java
@@ -20,6 +20,9 @@
 
 public class AuthenticatorPropertyConstants {
 
+    public static final String TAG_2FA = "2FA";
+    public static final String TAG_CUSTOM = "Custom";
+
     /**
      * The Defined by Types - SYSTEM: system define authenticator, USER: user defined authentication extension.
      */