Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this the correct contextIdentifier? #34

Open
mefarazath opened this issue Aug 10, 2017 · 0 comments
Open

Is this the correct contextIdentifier? #34

mefarazath opened this issue Aug 10, 2017 · 0 comments

Comments

@mefarazath
Copy link
Contributor

Noticed we are using request.getRequestedSessionId() as the context identifier in [1]? Is this the expected one? We usually use sessionDataKey as in [2] as the context identifier or in the case of OAuth we use the 'state' parameter.

[1]

public String getContextIdentifier(HttpServletRequest request) {
return request.getRequestedSessionId();
}

[2] https://github.com/wso2-extensions/identity-outbound-auth-passive-sts/blob/master/components/org.wso2.carbon.identity.application.authenticator.passive.sts/src/main/java/org/wso2/carbon/identity/application/authenticator/passive/sts/PassiveSTSAuthenticator.java#L130-L149

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant