Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Root Org Template Resolving Edge Case #418

Merged

Conversation

dhaura
Copy link
Contributor

@dhaura dhaura commented Dec 11, 2024

Purpose

  • When minimum org hierarchy depth is 1, resource traversal aggregation strategies do not check if a resource is available in the root organization even for a resource requested for the root organization. This PR fixes this issue.

Related Issues

@jenkins-is-staging
Copy link

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 47.28%. Comparing base (59e4504) to head (5fc36b6).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ervice/strategy/FirstFoundAggregationStrategy.java 50.00% 0 Missing and 2 partials ⚠️
.../service/strategy/MergeAllAggregationStrategy.java 50.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #418      +/-   ##
============================================
+ Coverage     46.94%   47.28%   +0.34%     
- Complexity     1068     1080      +12     
============================================
  Files           125      125              
  Lines          7017     7021       +4     
  Branches        845      849       +4     
============================================
+ Hits           3294     3320      +26     
+ Misses         3415     3397      -18     
+ Partials        308      304       -4     
Flag Coverage Δ
unit 32.00% <50.00%> (+0.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12271554899
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12271554899

@dhaura dhaura merged commit fa16669 into wso2-extensions:main Dec 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants