Add organization configuration service #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dewniMW
pushed a commit
to dewniMW/identity-organization-management-1
that referenced
this pull request
Sep 20, 2023
… release v1.3.15
dewniMW
pushed a commit
to dewniMW/identity-organization-management-1
that referenced
this pull request
Sep 20, 2023
… for next development iteration
dewniMW
force-pushed
the
config-service
branch
3 times, most recently
from
49044cb to
3c12979
Compare
dewniMW
force-pushed
the
config-service
branch
from
3c12979 to
2c9b001
Compare
AnuradhaSK
reviewed
Sep 20, 2023
...ain/java/org/wso2/carbon/identity/organization/config/service/OrganizationConfigManager.java
Outdated
Show resolved
Hide resolved
AnuradhaSK
reviewed
Sep 20, 2023
| * @throws OrganizationConfigException The exception thrown when an error occurs while adding the discovery | ||
| * configuration. | ||
| */ | ||
| void addDiscoveryConfiguration(DiscoveryConfig discoveryConfig) throws OrganizationConfigException; |
There was a problem hiding this comment.
Does that configuration manager get tenant id/tenant domain from the thread local? Is that the reason not to pass the tenant id/ domain from this service level it self ?
There was a problem hiding this comment.
yes it is picked from the thread local.
refer: https://github.com/wso2/carbon-identity-framework/blob/c750169c4818afed19155b8a0fbd9549b63ae115/components/configuration-mgt/org.wso2.carbon.identity.configuration.mgt.core/src/main/java/org/wso2/carbon/identity/configuration/mgt/core/dao/impl/ConfigurationDAOImpl.java#L689
…e/src/main/java/org/wso2/carbon/identity/organization/config/service/OrganizationConfigManager.java Co-authored-by: Anuradha Karunarathna <[email protected]>
AnuradhaSK
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: wso2/product-is#16728