Self-contained Magic Link Authenticator #25

Yoshani · 2022-10-26T13:25:42Z

Purpose

In the current implementation, the MagicLink authenticator is dependent on the identifier first to authenticate and resolve the user. But ideally, we should improve the MagicLink authenticator to embed the functionality of the identifier first authenticator to resolve the user using a given identifier.

This PR introduces identifier first capabilities into the Magic Link Authenticator.

Related Issues

Issue Improving MagicLink as a self-contained authenticator wso2/product-is#15145

Related PRs

PR Avoid IDF check in Magic Link only flow wso2/carbon-identity-framework#4337

...ava/org/wso2/carbon/identity/application/authenticator/magiclink/MagicLinkAuthenticator.java

...o2/carbon/identity/application/authenticator/magiclink/util/MagicLinkAuthErrorConstants.java

jenkins-is-staging · 2022-11-22T04:34:51Z

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/3520393972

jenkins-is-staging · 2022-11-22T04:41:38Z

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/3520393972
Status: failure

jenkins-is-staging · 2022-11-22T07:56:04Z

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/3521421897

jenkins-is-staging · 2022-11-22T09:37:06Z

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/3521421897
Status: success

jenkins-is-staging

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/3521421897

...ava/org/wso2/carbon/identity/application/authenticator/magiclink/MagicLinkAuthenticator.java

Yoshani · 2022-11-24T06:44:53Z

Manual Testing

Manual test round performed and verified.

...org/wso2/carbon/identity/application/authenticator/magiclink/MagicLinkAuthenticatorTest.java

hwupathum · 2023-06-04T18:42:34Z

components/org.wso2.carbon.identity.application.authenticator.magiclink/pom.xml

@@ -1,18 +1,20 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!--
-~ Copyright (c) 2022, WSO2 Inc. (http://www.wso2.org) All Rights Reserved.
+~ Copyright (c) 2022, WSO2 LLC. (http://www.wso2.org) All Rights Reserved.


Fix the licence header

hwupathum · 2023-06-04T18:44:19Z

pom.xml

@@ -1,18 +1,20 @@
 <?xml version="1.0" encoding="utf-8"?>
 <!--
-~ Copyright (c) 2021, WSO2 Inc. (http://www.wso2.org) All Rights Reserved.
+~ Copyright (c) 2021, WSO2 LLC. (http://www.wso2.org) All Rights Reserved.


Fix the licence header

hwupathum · 2023-06-04T18:44:55Z

...o2/carbon/identity/application/authenticator/magiclink/util/MagicLinkAuthErrorConstants.java

@@ -0,0 +1,79 @@
+/*
+ * Copyright (c) 2022, WSO2 LLC. (http://www.wso2.org) All Rights Reserved.


Fix licence header

hwupathum · 2023-06-04T18:45:35Z

...carbon/identity/application/authenticator/magiclink/internal/MagicLinkServiceDataHolder.java

@@ -1,7 +1,7 @@
 /*
- * Copyright (c) 2021, WSO2 Inc. (http://www.wso2.org) All Rights Reserved.
+ * Copyright (c) 2021, WSO2 LLC. (http://www.wso2.org) All Rights Reserved.


hwupathum · 2023-06-04T18:45:53Z

...ity/application/authenticator/magiclink/internal/MagicLinkAuthenticatorServiceComponent.java

@@ -1,7 +1,7 @@
 /*
- * Copyright (c) 2021, WSO2 Inc. (http://www.wso2.org) All Rights Reserved.
+ * Copyright (c) 2021, WSO2 LLC. (http://www.wso2.org) All Rights Reserved.


hwupathum · 2023-06-04T18:46:32Z

...ava/org/wso2/carbon/identity/application/authenticator/magiclink/MagicLinkAuthenticator.java

+     * This method is used to resolve the user from authentication response from identifier handler.
+     *
+     * @param request  The httpServletRequest.
+     * @param context  The authentication context.


Add @return

hwupathum · 2023-06-04T18:47:59Z

...org/wso2/carbon/identity/application/authenticator/magiclink/MagicLinkAuthenticatorTest.java

@@ -1,9 +1,9 @@
 /*
- * Copyright (c) 2022, WSO2 Inc. (http://www.wso2.org) All Rights Reserved.
+ * Copyright (c) 2022, WSO2 LLC. (http://www.wso2.org) All Rights Reserved.


hwupathum · 2023-06-04T18:49:22Z

...ava/org/wso2/carbon/identity/application/authenticator/magiclink/MagicLinkAuthenticator.java

+    private AuthenticationContext authenticationContext;
+
+    @Override
+    public AuthenticatorFlowStatus process(HttpServletRequest request, HttpServletResponse response,


Add method comments for public methods

hwupathum · 2023-06-04T18:51:56Z

...ava/org/wso2/carbon/identity/application/authenticator/magiclink/MagicLinkAuthenticator.java

+        if (context.isLogoutRequest()) {
+            return AuthenticatorFlowStatus.SUCCESS_COMPLETED;
+        }
+        if (getName().equals(context.getProperty(FrameworkConstants.LAST_FAILED_AUTHENTICATOR))) {


Use StringUtils. equals() to avoid NPE

Yoshani · 2023-07-05T04:51:56Z

Comments fixed by #33

Yoshani and others added 3 commits October 26, 2022 18:50

Add process auth response method for idf

d0cf9e9

Merge branch 'wso2-extensions:main' into self-contained-auth

b9a3052

Add auth error constants

6606403

Yoshani commented Oct 27, 2022

View reviewed changes

...ava/org/wso2/carbon/identity/application/authenticator/magiclink/MagicLinkAuthenticator.java Outdated Show resolved Hide resolved

Yoshani commented Oct 27, 2022

View reviewed changes

...ava/org/wso2/carbon/identity/application/authenticator/magiclink/MagicLinkAuthenticator.java Outdated Show resolved Hide resolved

Yoshani commented Oct 27, 2022

View reviewed changes

...ava/org/wso2/carbon/identity/application/authenticator/magiclink/MagicLinkAuthenticator.java Outdated Show resolved Hide resolved

Yoshani commented Oct 27, 2022

View reviewed changes

...ava/org/wso2/carbon/identity/application/authenticator/magiclink/MagicLinkAuthenticator.java Outdated Show resolved Hide resolved

Yoshani commented Oct 27, 2022

View reviewed changes

...ava/org/wso2/carbon/identity/application/authenticator/magiclink/MagicLinkAuthenticator.java Outdated Show resolved Hide resolved

Yoshani added 3 commits October 28, 2022 14:22

refactor processIdf method

23fce29

use MapUtils

61c01a7

add diagnostic logs

a7d3bfd

chamathns reviewed Oct 30, 2022

View reviewed changes

...ava/org/wso2/carbon/identity/application/authenticator/magiclink/MagicLinkAuthenticator.java Outdated Show resolved Hide resolved

chamathns reviewed Oct 30, 2022

View reviewed changes

...ava/org/wso2/carbon/identity/application/authenticator/magiclink/MagicLinkAuthenticator.java Outdated Show resolved Hide resolved

chamathns reviewed Oct 30, 2022

View reviewed changes

...ava/org/wso2/carbon/identity/application/authenticator/magiclink/MagicLinkAuthenticator.java Outdated Show resolved Hide resolved

chamathns reviewed Oct 30, 2022

View reviewed changes

...ava/org/wso2/carbon/identity/application/authenticator/magiclink/MagicLinkAuthenticator.java Outdated Show resolved Hide resolved

chamathns reviewed Oct 30, 2022

View reviewed changes

...ava/org/wso2/carbon/identity/application/authenticator/magiclink/MagicLinkAuthenticator.java Outdated Show resolved Hide resolved

fix suggestions

8b07900

sahandilshan reviewed Oct 31, 2022

View reviewed changes

...o2/carbon/identity/application/authenticator/magiclink/util/MagicLinkAuthErrorConstants.java Outdated Show resolved Hide resolved

Yoshani added 12 commits October 31, 2022 10:29

add diagnostic log constants

1647fe6

add fullstop to comments

4955761

extract user validation to private method

52e8e6e

restructure code

cb45302

restructure code

eb79144

resolve checkstyle errors

255e23e

move method

60c924e

fix indentation in comments

15a5590

refactor resolveUserFromUserStore method

5085318

reduce cognitive complexity

d8af09b

refactor code

6371e1e

rename method

fcdcbdc

fix tests

a80a575

clean code

f3b13a7

jenkins-is-staging previously approved these changes Nov 22, 2022

View reviewed changes

log error during email fail event

f7856c5

Yoshani dismissed jenkins-is-staging’s stale review via f7856c5 November 23, 2022 10:31

chamathns reviewed Nov 23, 2022

View reviewed changes

...ava/org/wso2/carbon/identity/application/authenticator/magiclink/MagicLinkAuthenticator.java Outdated Show resolved Hide resolved

chamathns previously approved these changes Nov 23, 2022

View reviewed changes

remove extra space

c54c24b

Yoshani dismissed chamathns’s stale review via c54c24b November 23, 2022 13:20

chamathns previously approved these changes Nov 23, 2022

View reviewed changes

Yoshani mentioned this pull request Nov 23, 2022

Remove dependency of Magic Link Authenticator on IDF wso2/identity-apps#3654

Merged

9 tasks

chamathns reviewed Nov 24, 2022

View reviewed changes

...org/wso2/carbon/identity/application/authenticator/magiclink/MagicLinkAuthenticatorTest.java Outdated Show resolved Hide resolved

update header

d9e5965

Yoshani dismissed chamathns’s stale review via d9e5965 November 24, 2022 07:04

chamathns approved these changes Nov 24, 2022

View reviewed changes

chamathns merged commit e800f12 into wso2-extensions:main Nov 24, 2022

This was referenced Nov 30, 2022

Self-contained magic link authenticator wso2/docs-is#3563

Merged

Improving MagicLink as a self-contained authenticator wso2/product-is#15145

Closed

Remove IDF warning wso2/identity-apps#3667

Merged

hwupathum reviewed Jun 4, 2023

View reviewed changes

Yoshani mentioned this pull request Jul 5, 2023

Fix suggestions #33

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Self-contained Magic Link Authenticator #25

Self-contained Magic Link Authenticator #25

Yoshani commented Oct 26, 2022 •

edited

Loading

jenkins-is-staging commented Nov 22, 2022

jenkins-is-staging commented Nov 22, 2022

jenkins-is-staging commented Nov 22, 2022

jenkins-is-staging commented Nov 22, 2022

jenkins-is-staging left a comment

Yoshani commented Nov 24, 2022

hwupathum Jun 4, 2023

hwupathum Jun 4, 2023

hwupathum Jun 4, 2023

hwupathum Jun 4, 2023

hwupathum Jun 4, 2023

hwupathum Jun 4, 2023

hwupathum Jun 4, 2023

hwupathum Jun 4, 2023

hwupathum Jun 4, 2023

Yoshani commented Jul 5, 2023

		@@ -0,0 +1,79 @@
		/*
		* Copyright (c) 2022, WSO2 LLC. (http://www.wso2.org) All Rights Reserved.

Self-contained Magic Link Authenticator #25

Self-contained Magic Link Authenticator #25

Conversation

Yoshani commented Oct 26, 2022 • edited Loading

Purpose

Related Issues

Related PRs

jenkins-is-staging commented Nov 22, 2022

jenkins-is-staging commented Nov 22, 2022

jenkins-is-staging commented Nov 22, 2022

jenkins-is-staging commented Nov 22, 2022

jenkins-is-staging left a comment

Choose a reason for hiding this comment

Yoshani commented Nov 24, 2022

Manual Testing

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Yoshani commented Jul 5, 2023

Yoshani commented Oct 26, 2022 •

edited

Loading