Fix admin role mandatory attribute update #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnuradhaSK
reviewed
Oct 26, 2023
Comment on lines
93
to
94
| throws IdentitySCIMException { | ||
| Map<String, String> attributes = new HashMap<>(); |
There was a problem hiding this comment.
Suggested change
| throws IdentitySCIMException { | |
| Map<String, String> attributes = new HashMap<>(); | |
| throws IdentitySCIMException { | |
| Map<String, String> attributes = new HashMap<>(); |
AnuradhaSK
reviewed
Oct 26, 2023
| * @throws IdentitySCIMException if any error occurs while adding admin role attributes. | ||
| */ | ||
| public void addAdminRoleMandatoryAttributes(String roleName) | ||
| throws IdentitySCIMException { |
There was a problem hiding this comment.
can't we move the line 93 above
AnuradhaSK
reviewed
Oct 26, 2023
| public void addAdminRoleMandatoryAttributes(String roleName) | ||
| throws IdentitySCIMException { | ||
| Map<String, String> attributes = new HashMap<>(); | ||
| String tenantDomain = IdentityTenantUtil.getTenantDomain(1); |
There was a problem hiding this comment.
Suggested change
| String tenantDomain = IdentityTenantUtil.getTenantDomain(1); | |
| String tenantDomain = IdentityTenantUtil.getTenantDomain(<use correct tenant id>); |
AnuradhaSK
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the mandatory id attribute of admin role was update using a random UUID. However, in the current role v2 implementation, we set the UUID from the kernel to the UM_HYBRID_ROLE table. Instead of updating the ID attribute of the role with a random UUID, we set the role id attribute by retrieving the UUID from the UM_HYBRID_ROLE table.
Part of wso2/product-is#16363