Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add realm configuration to get primary user store domain name. #451

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add realm configuration to get primary user store domain name. #451

wants to merge 1 commit into from

Conversation

DInuwan97
Copy link

@DInuwan97 DInuwan97 commented Dec 5, 2022 •
edited by rksk
Loading

@DInuwan97 DInuwan97 closed this Dec 5, 2022
@DInuwan97 DInuwan97 reopened this Dec 5, 2022
@wso2-extensions wso2-extensions deleted a comment from DInuwan97 Dec 5, 2022
deshankoswatte
deshankoswatte reviewed Dec 6, 2022
View reviewed changes
Copy link
Member

@deshankoswatte deshankoswatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor suggestion.

...im2.common/src/test/java/org/wso2/carbon/identity/scim2/common/impl/SCIMUserManagerTest.java Outdated Show resolved Hide resolved
deshankoswatte
deshankoswatte previously approved these changes Dec 6, 2022
View reviewed changes
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/3631986673

@DInuwan97 DInuwan97 requested review from rksk and deshankoswatte and removed request for deshankoswatte December 6, 2022 17:54
@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/3631986673
Status: success

jenkins-is-staging
jenkins-is-staging previously approved these changes Dec 6, 2022
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/3631986673

@rksk rksk force-pushed the extenssions-dev branch 2 times, most recently from 832dde6 to 9388912 Compare December 7, 2022 07:01
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/3636623376

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/3636623376
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/3637975994

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/3637975994
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Dec 7, 2022
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/3637975994

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@deshankoswatte deshankoswatte deshankoswatte left review comments

@rksk rksk Awaiting requested review from rksk

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SCIM2 GET user call is responding 500, if a custom domain name set in PRIMARY userstore.
4 participants
@DInuwan97 @jenkins-is-staging @rksk @deshankoswatte