Merge pull request #554 from SujanSanjula96/add-check

Add empty check before updating IDP groups
wso2-extensions · Jun 6, 2024 · 332d91e · 332d91e
2 parents 77d9cb9 + 003b3b5
commit 332d91e
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/...m2.common/src/main/java/org/wso2/carbon/identity/scim2/common/impl/SCIMRoleManagerV2.java b/...m2.common/src/main/java/org/wso2/carbon/identity/scim2/common/impl/SCIMRoleManagerV2.java
@@ -163,8 +163,10 @@ public RoleV2 createRole(RoleV2 role)
             RoleBasicInfo roleBasicInfo =
                     roleManagementService.addRole(role.getDisplayName(), role.getUsers(), localGroupIds,
                             permissionList, audienceType, role.getAudienceValue(), tenantDomain);
-            roleManagementService.updateIdpGroupListOfRole(roleBasicInfo.getId(), idpGroupList, new ArrayList<>(),
-                    tenantDomain);
+            if (isNotEmpty(idpGroupList)) {
+                roleManagementService.updateIdpGroupListOfRole(roleBasicInfo.getId(), idpGroupList, new ArrayList<>(),
+                        tenantDomain);
+            }
             RoleV2 createdRole = new RoleV2();
             createdRole.setId(roleBasicInfo.getId());
             String locationURI = SCIMCommonUtils.getSCIMRoleV2URL(roleBasicInfo.getId());