Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ext_application_version field to dcr apps #2574

Merged
merged 8 commits into from
Oct 8, 2024

Conversation

mpmadhavig
Copy link
Contributor

@mpmadhavig mpmadhavig commented Sep 19, 2024

Proposed changes in this pull request

$subject

In this PR we add,

  1. App version as an external param to the DCR EP.
  2. Set sub claim and introspect resp logic to honor the below behavior.
    • If app version satisfies apply the change.
    • else check server config, if its on apply the change.

Related Issues

@mpmadhavig mpmadhavig force-pushed the app-versioning branch 2 times, most recently from 3e3eba3 to 937cc16 Compare September 26, 2024 10:22
shashimalcse
shashimalcse previously approved these changes Oct 6, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 46.00000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 55.83%. Comparing base (74ead1f) to head (26b1efe).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...g/wso2/carbon/identity/oauth2/util/OAuth2Util.java 0.00% 8 Missing ⚠️
...arbon/identity/oauth2/token/AccessTokenIssuer.java 0.00% 7 Missing ⚠️
...tity/oauth2/dcr/endpoint/dto/UpdateRequestDTO.java 40.00% 3 Missing ⚠️
...carbon/identity/oauth/dcr/service/DCRMService.java 50.00% 3 Missing ⚠️
...ntity/oauth/dcr/bean/ApplicationUpdateRequest.java 50.00% 2 Missing ⚠️
...tity/oauth2/validators/TokenValidationHandler.java 77.77% 0 Missing and 2 partials ⚠️
...entity/oauth2/dcr/endpoint/dto/ApplicationDTO.java 75.00% 1 Missing ⚠️
...o2/carbon/identity/oauth/dcr/bean/Application.java 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2574      +/-   ##
============================================
- Coverage     55.91%   55.83%   -0.08%     
+ Complexity     8020     8013       -7     
============================================
  Files           632      632              
  Lines         45764    45868     +104     
  Branches       7276     7300      +24     
============================================
+ Hits          25587    25610      +23     
- Misses        16464    16542      +78     
- Partials       3713     3716       +3     
Flag Coverage Δ
unit 38.11% <46.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11211295886
Status: failure

@jenkins-is-staging
Copy link

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11211295886
Status: failure

@jenkins-is-staging
Copy link

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11228546765
Status: failure

@jenkins-is-staging
Copy link

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11228546765
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11228546765

@mpmadhavig mpmadhavig merged commit c83cc96 into wso2-extensions:master Oct 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants