Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add useClientIdAsSubClaimForAppTokens and omitUsernameInIntrospectionRespForAppTokens configs to app #2545

Merged

Conversation

mpmadhavig
Copy link
Contributor

@mpmadhavig mpmadhavig commented Aug 14, 2024

Proposed changes in this pull request

useClientIdAsSubClaimForAppTokens and omitUsernameInIntrospectionRespForAppTokens configs are being introduce to support the on the fly migration for client apps for the issue mentioned in [1].

The configs values will be default false for old apps, default true for new apps. Old app owners can do necessary changes and change the config value to true marking a successful migration.

Please note that the behavioral changes introduced in this PR will only get effective, only when the below configs are enabled.

[oauth]
use_client_id_as_sub_claim_for_app_tokens = false
remove_username_from_introspection_response_for_app_tokens = false

[1] wso2/product-is#16060

Related Issues:

@mpmadhavig mpmadhavig force-pushed the feature-enable-disable-config-api branch from c63ba02 to bef8688 Compare August 15, 2024 08:11
@mpmadhavig mpmadhavig force-pushed the feature-enable-disable-config-api branch from bef8688 to fc19a14 Compare August 15, 2024 09:02
public static final boolean USE_CLIENT_ID_AS_SUB_CLAIM_FOR_APP_TOKENS_NEW_APP_DEFAULT_VALUE = true;
public static final String OMIT_USERNAME_IN_INTROSPECTION_RESP_FOR_APP_TOKEN =
"omitUsernameInIntrospectionRespForAppTokens";
public static final boolean OMIT_USERNAME_IN_INTROSPECTION_RESP_FOR_APP_TOKEN_OLD_APP_DEFAULT_VALUE =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove. This was used earlier, then replaced usage with parse boolean.
Removed with a52e255

@mpmadhavig mpmadhavig force-pushed the feature-enable-disable-config-api branch from 11d8afc to 0db749d Compare August 21, 2024 03:11
@jenkins-is-staging
Copy link

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/10484839077
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/10484839077

@mpmadhavig mpmadhavig merged commit 28073be into wso2-extensions:master Aug 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants