-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add useClientIdAsSubClaimForAppTokens and omitUsernameInIntrospectionRespForAppTokens configs to app #2545
Add useClientIdAsSubClaimForAppTokens and omitUsernameInIntrospectionRespForAppTokens configs to app #2545
Conversation
…ection resp logic.
c63ba02
to
bef8688
Compare
bef8688
to
fc19a14
Compare
public static final boolean USE_CLIENT_ID_AS_SUB_CLAIM_FOR_APP_TOKENS_NEW_APP_DEFAULT_VALUE = true; | ||
public static final String OMIT_USERNAME_IN_INTROSPECTION_RESP_FOR_APP_TOKEN = | ||
"omitUsernameInIntrospectionRespForAppTokens"; | ||
public static final boolean OMIT_USERNAME_IN_INTROSPECTION_RESP_FOR_APP_TOKEN_OLD_APP_DEFAULT_VALUE = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove. This was used earlier, then replaced usage with parse boolean.
Removed with a52e255
11d8afc
to
0db749d
Compare
PR builder started |
PR builder completed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/10484839077
Proposed changes in this pull request
The configs values will be default false for old apps, default true for new apps. Old app owners can do necessary changes and change the config value to true marking a successful migration.
[1] wso2/product-is#16060
Related Issues: