Add allowedScopes as query string in consent page #2297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 8, 2023
sahandilshan
force-pushed
the
unregistered_scope
branch
from
5197be6 to
46bbc6e
Compare
|
PR builder started |
|
PR builder completed |
sahandilshan
force-pushed
the
unregistered_scope
branch
from
46bbc6e to
5710195
Compare
|
PR builder started |
|
PR builder completed |
jenkins-is-staging
approved these changes
Dec 11, 2023
There was a problem hiding this comment.
Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/7162310751
chamathns
reviewed
Dec 11, 2023
| if (queryString.contains(REQUEST_URI) && params != null) { | ||
| StringBuilder queryStringBuilder = new StringBuilder(); | ||
| queryStringBuilder.append(entry.getQueryString()); | ||
| if (entry.getQueryString().contains(REQUEST_URI) && params != null) { |
There was a problem hiding this comment.
This is getting called here [1] and it's already checking whether the entry is null. And this is the only usage of that method.
[1] -
....oauth.endpoint/src/main/java/org/wso2/carbon/identity/oauth/endpoint/util/EndpointUtil.java
Outdated
Show resolved
Hide resolved
chamathns
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes in this pull request
Related Issue(s)