Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip passwordExpiryEventListener in authentication flow #903

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

PasinduYeshan
Copy link
Contributor

@PasinduYeshan PasinduYeshan commented Jan 9, 2025

Proposed changes in this pull request

  • Skip passwordExpiryEventListener in authentication flow
  • Pass domain qualified username.

Related Issues

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 51.03%. Comparing base (55bf5a4) to head (3ab3936).

Files with missing lines Patch % Lines
...d/expiry/listener/PasswordExpiryEventListener.java 66.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #903      +/-   ##
============================================
+ Coverage     50.91%   51.03%   +0.11%     
- Complexity     2431     2434       +3     
============================================
  Files           298      298              
  Lines         17979    17983       +4     
  Branches       2585     2586       +1     
============================================
+ Hits           9154     9177      +23     
+ Misses         7673     7651      -22     
- Partials       1152     1155       +3     
Flag Coverage Δ
unit 38.54% <66.66%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/12686670121
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/12686670121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants